Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Naming #4390

Closed
travislopes opened this issue Jan 10, 2018 · 3 comments
Closed

Inconsistent Naming #4390

travislopes opened this issue Jan 10, 2018 · 3 comments
Labels
[Status] In Progress Tracking issues with work in progress [Status] Needs More Info Follow-up required in order to be actionable. [Type] Enhancement A suggestion for improvement.

Comments

@travislopes
Copy link
Contributor

With recent changes to Gutenberg, there are naming inconsistencies surrounding the Block sidebar settings.

In the ellipses drop down next to a block, there is a "Hide/Show Advanced Settings" link. Clicking on the link focuses the "Format" (formally "Block") sidebar tab.

This can cause confusion in multiple ways.

We're currently building out a (soon to be released) Gravity Forms block to allow customers to display their forms within their posts and pages with more in-depth configuration options.

screen shot 2018-01-10 at 4 41 10 pm

Within the list of block settings, there are a group that are hidden within an "Advanced Settings" accordion. These are both settings not frequently used and attributes previously available through the Gravity Forms shortcode that need to exist for backwards compatbility. Clicking on the "Show Advanced Settings" ellipses drop down link is now taking you to a sidebar that contains another "Advanced Settings" section.

screen shot 2018-01-10 at 4 41 33 pm

The sidebar tab name being "Format" is also confusing as none of the settings displayed in this block are formatting related; they all center around controlling the content displayed within the block.

Naming both the ellipses drop down link and the sidebar tab "Settings" or allowing developers to define both the drop down link and sidebar tabs names at the block level would resolve the confusion.

@carlhancock
Copy link

Making the labels for everything pluggable is the solution and it is something that should be done for extensibility.

Everything needs to be customizable. Plugins should be able to control their block, including what UI elements are called and their related settings.

People also use WordPress to build custom platforms and even web apps. They are going to want to be able to customize things like the labels and what things are called. The end result may not even be promoted as being WordPress. For example a hosted web site solution for restaurants. Or a hosted service for tour guide web sites. This is one of many ways that WordPress is used.

For those reasons making the labels customizable via code is something that should be possible.

@jeffpaul
Copy link
Member

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

@danielbachhuber danielbachhuber added the [Status] Needs More Info Follow-up required in order to be actionable. label May 14, 2018
@danielbachhuber
Copy link
Member

@travislopes @carlhancock Are there any remaining actionable items in this issue, or can it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Status] Needs More Info Follow-up required in order to be actionable. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants