Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block toolbar sometimes positioned incorrectly after dragging and dropping a block #44281

Closed
talldan opened this issue Sep 20, 2022 · 3 comments
Closed

Block toolbar sometimes positioned incorrectly after dragging and dropping a block #44281

talldan opened this issue Sep 20, 2022 · 3 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Regression Related to a regression in the latest release

Comments

@talldan
Copy link
Contributor

talldan commented Sep 20, 2022

Description

Sometimes when dragging and dropping a block the block toolbar will be positioned incorrectly

Step-by-step reproduction instructions

  1. Add some blocks
  2. Drag and drop a few times
  3. Observe that sometimes after dropping the block, the toolbar isn't visible. Other times it'll be positioned incorrectly

Screenshots, screen recording, code snippet

Kapture.2022-09-20.at.11.05.51.mp4

Environment info

Gutenberg trunk

Mac OS / Brave

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@talldan talldan added [Feature] Blocks Overall functionality of blocks [Type] Regression Related to a regression in the latest release [Feature] Drag and Drop Drag and drop functionality when working with blocks labels Sep 20, 2022
@talldan talldan mentioned this issue Sep 20, 2022
Open
67 tasks
@talldan talldan changed the title Block toolbar sometimes positioned incorrectly when dragging and dropping a block Block toolbar sometimes positioned incorrectly after dragging and dropping a block Sep 20, 2022
@talldan talldan mentioned this issue Sep 21, 2022
Merged
@ciampo
Copy link
Contributor

ciampo commented Sep 21, 2022

#44301 Fixes the incorrect positioning.

The disappearing will need a separate fix — I will look into it and see what I can discover

@glendaviesnz
Copy link
Contributor

@talldan with #44301 cherry picked into 6.1 do you think we can close this one now, and open a new one for the disappearing if needed?

@talldan
Copy link
Contributor Author

talldan commented Sep 30, 2022

Yeah, I'm happy with that. IMO, the disappearing thing is very low priority. I don't think most people will notice it.

@talldan talldan closed this as completed Sep 30, 2022
Repository owner moved this from Triage to Done in WordPress 6.1 Editor Tasks Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Regression Related to a regression in the latest release
Projects
No open projects
WordPress 6.1 Editor Tasks
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@talldan @ciampo @glendaviesnz