Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery block: editing a gallery uses "Insert gallery" button #4491

Closed
jeherve opened this issue Jan 15, 2018 · 2 comments
Closed

Gallery block: editing a gallery uses "Insert gallery" button #4491

jeherve opened this issue Jan 15, 2018 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended
Milestone

Comments

@jeherve
Copy link
Contributor

jeherve commented Jan 15, 2018

Issue Overview

Editing a gallery block uses "Insert gallery" modal instead of Core's "Edit Gallery" modal.

Steps to Reproduce (for bugs)

  1. Create a new post with the Gutenberg editor.
  2. In this post, insert a gallery block.
  3. Publish the post.
  4. Later, come back and edit that post in the Gutenberg editor.
  5. Click on the Edit icon on top of the gallery.
  6. The modal that loads, while allowing you to add or remove images, says "Insert gallery".

Expected Behavior

I expected to be able to edit the gallery, and it took me a second to understand that I could do this through this screen:

screenshot 2018-01-15 at 20 44 46

Possible Solution

  • When editing a gallery in WP, you get a specific "Edit Gallery" modal. Gutenberg could open this:

screenshot 2018-01-15 at 20 39 22

Related Issues and/or PRs

#1704

Details

  • Using Chrome, WP 4.9.1
  • Gutenberg 2.0.0
@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media labels Jan 23, 2018
@karmatosed karmatosed added this to the Merge Proposal milestone Jan 25, 2018
@mellis32
Copy link

Today I tried to make a gallery and noticed this. I also was not able to resize the gallery.

@karmatosed karmatosed modified the milestones: Merge Proposal, Merge Proposal: Media Apr 12, 2018
@jorgefilipecosta
Copy link
Member

Thank you for reporting this issue @jeherve, it was fixed with the merge of #2488.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants