Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecations: fixture missing for new File block deprecation #45185

Open
glendaviesnz opened this issue Oct 21, 2022 · 0 comments
Open

Deprecations: fixture missing for new File block deprecation #45185

glendaviesnz opened this issue Oct 21, 2022 · 0 comments
Assignees
@glendaviesnz
Labels
[Block] File Affects the File Block [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@glendaviesnz
Copy link
Contributor

Description

The File block is missing a fixture for the new deprecation added here. Adding a fixture to cover this was causing a PHP unit test error, and it was important to get the deprecation merged in order to go into 6.1 so adding the fixture can be handled separately.

Step-by-step reproduction instructions

...

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@glendaviesnz glendaviesnz self-assigned this Oct 21, 2022
@glendaviesnz glendaviesnz added the [Block] File Affects the File Block label Oct 21, 2022
@glendaviesnz glendaviesnz mentioned this issue Oct 21, 2022
Merged
@jordesign jordesign added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glendaviesnz glendaviesnz

Labels
[Block] File Affects the File Block [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordesign @glendaviesnz