Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote style two is easy to confuse with comments #4526

Closed
karmatosed opened this issue Jan 16, 2018 · 3 comments
Closed

Quote style two is easy to confuse with comments #4526

karmatosed opened this issue Jan 16, 2018 · 3 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

This is more a potential future clash if we have collaborative editing, but it's also something that goes against a widely interpreted icon. Right now we have this for the second quote style icon:

2018-01-16 at 20 05

This is easy to confuse with adding a comment. Yes, we don't have comments and clicking it doesn't add a comment, but we should consider it's use.

@karmatosed karmatosed added the [Type] Enhancement A suggestion for improvement. label Jan 16, 2018
@melchoyce
Copy link
Contributor

What if we changed the icons to two labels?

  • Style 1
  • Style 2

@karmatosed
Copy link
Member Author

My only wonder there is we don’t use words anywhere else. I’m saying that I don’t know how we show them any other way unless have a very niche icon design. I wonder if merging as a drop down could also work.

@karmatosed
Copy link
Member Author

As quotes are being worked on, split into separate blocks lets close this and iterate there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants