Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-only locked patterns: move "Modify" to elllipsis menu #45263

Closed
1 task
jasmussen opened this issue Oct 25, 2022 · 5 comments · Fixed by #45391
Closed
1 task

Content-only locked patterns: move "Modify" to elllipsis menu #45263

jasmussen opened this issue Oct 25, 2022 · 5 comments · Fixed by #45391
Assignees
Labels
Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@jasmussen
Copy link
Contributor

Followup to #43037. When you add "templateLock":"contentOnly" manually to the code of a group block (no UI yet), the pattern becomes content-only locked and flattens nested blocks, for simpler editing:

content only locked

There's a big "Modify" button in the toolbar, which unlocks the patterns you can edit, delete, move around nested blocks.

  • Let's move this button to the ellipsis menu, to reduce its prominence.

An adjacent question/conversation is whether we should rename the button to "Edit", and have it invoke focus mode at the same time. This could use design feedback. CC: @WordPress/gutenberg-design

@jasmussen jasmussen added [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Oct 25, 2022
@jasmussen jasmussen added the Needs Dev Ready for, and needs developer efforts label Oct 25, 2022
@jasmussen
Copy link
Contributor Author

Added "Needs dev" as the moving to ellipsis menu task can be completed now, despite the open question.

@jasmussen
Copy link
Contributor Author

Related: #45264

@jameskoster
Copy link
Contributor

Considering #45264, 'Edit' may be out of the question.

no UI yet

Perhaps we should explore this first? It may be that the solution is a toggle, which could make the 'modify' button unnecessary.

@jasmussen
Copy link
Contributor Author

'Edit' may be out of the question.

Actually I thought it neat to combine the two. Modify and Edit could be the same, no?

@jameskoster
Copy link
Contributor

Oh yes, that would be good to try :)

@jorgefilipecosta jorgefilipecosta self-assigned this Oct 25, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 28, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants