Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: Remove default dark background #46291

Closed
t-hamano opened this issue Dec 4, 2022 · 2 comments · Fixed by #46314
Closed

Site Editor: Remove default dark background #46291

t-hamano opened this issue Dec 4, 2022 · 2 comments · Fixed by #46314
Assignees
@ntsekouras
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Dec 4, 2022

What problem does this address?

If the Gutenberg plugin is enabled and the theme doesn't explicitly specify a background color for the site, a dark color will be applied to the background, making it difficult to recognize text and blocks.

Empty Theme with Gutenberg plugin disabled

wp

Empty Theme with Gutenberg plugin enabled

gb

What is your proposed solution?

As in the past, I believe that the background color should not be changed unless the background color is specified on the theme.
@t-hamano t-hamano added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Package] Edit Site /packages/edit-site [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Package] Edit Site /packages/edit-site labels Dec 4, 2022
@ntsekouras
Copy link
Contributor

It's the same result in zoom-out view. Should it default to white? 🤔 --cc @jasmussen @jameskoster

@jasmussen
Copy link
Contributor

White sounds good 👍

@ntsekouras ntsekouras mentioned this issue Dec 5, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 5, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Dec 6, 2022
@ntsekouras ntsekouras mentioned this issue Dec 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ntsekouras ntsekouras

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Milestone
No milestone
4 participants
@jasmussen @ntsekouras @priethor @t-hamano