Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert from URL accepts plain text and assumes is an image blob #46326

Open
johngodley opened this issue Dec 6, 2022 · 0 comments
Open

Insert from URL accepts plain text and assumes is an image blob #46326

johngodley opened this issue Dec 6, 2022 · 0 comments
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended

Comments

@johngodley
Copy link
Contributor

johngodley commented Dec 6, 2022

Description

If you type some text into the 'insert from URL' dialog it then assumes it is an image blob, turns the block into a valid image, and lets you change settings and upload it the server.

Secondary to this, the upload icon appears even if hasUploadPermissions is false.

Step-by-step reproduction instructions

  1. Add an image block
  2. Click 'Insert from URL'
  3. Enter a word like 'hello'
  4. Submit and the block becomes a valid image block (i.e. you can change image settings). Also note that the 'upload external image' button is now available
  5. Click the upload button and get undefined: Sorry, this file type is not supported here.

Screenshots, screen recording, code snippet

image
image
image

Environment info

  • Gutenberg 14.7.0 RC 1
  • WordPress 6.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@johngodley johngodley added [Type] Bug An existing feature does not function as intended [Feature] Media Anything that impacts the experience of managing media [Block] Image Affects the Image Block labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant