Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Reset to defaults action is not working #46484

Closed
andrewserong opened this issue Dec 12, 2022 · 3 comments · Fixed by #46486
Closed

Global Styles: Reset to defaults action is not working #46484

andrewserong opened this issue Dec 12, 2022 · 3 comments · Fixed by #46486
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Regression Related to a regression in the latest release

Comments

@andrewserong
Copy link
Contributor

andrewserong commented Dec 12, 2022

Description

In trunk, within global styles, the Reset to defaults action appears not to be working. From running a git bisect, it appears that the change that introduced the regression was #44770 (the PR that introduced the new browse mode).

Kudos @tellthemachines for flagging the issue!

Step-by-step reproduction instructions

On trunk, open up global styles in a site that has user styles, and attempt to reset the global styles back to the theme defaults. As of #44770, it appears that the drop-down control to reset to defaults no longer works.

For a commit that still works (e.g. prior to #44770) you can checkout 51f0b77, or really any prior to #44770.

Screenshots, screen recording, code snippet

trunk when it was working previously
2022-12-13 10 38 51 2022-12-13 10 37 24

Environment info

  • WP 6.1.1
  • Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@andrewserong andrewserong added [Type] Regression Related to a regression in the latest release Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Dec 12, 2022
@andrewserong
Copy link
Contributor Author

Pinging a few folks who worked on #44770 and/or reviewed: @youknowriad, @ntsekouras, @scruffian for visibility.

@ramonjd
Copy link
Member

ramonjd commented Dec 13, 2022

Looks like it's because <SidebarComplementaryAreaFills /> has been placed outside the global context provider

@andrewserong
Copy link
Contributor Author

We have a fix open in: #46486

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Regression Related to a regression in the latest release
Projects
None yet
3 participants