Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One of the recent updates broke WP_HTML_Tag_Processor's PHPUnit tests #46588

Closed
anton-vlasenko opened this issue Dec 15, 2022 · 2 comments · Fixed by #46598
Closed

One of the recent updates broke WP_HTML_Tag_Processor's PHPUnit tests #46588

anton-vlasenko opened this issue Dec 15, 2022 · 2 comments · Fixed by #46598
Labels
[Type] Bug An existing feature does not function as intended

Comments

@anton-vlasenko
Copy link
Contributor

anton-vlasenko commented Dec 15, 2022

Description

I've noticed that these changes break PHPUnit tests on PHP 5.6:
https://github.com/WordPress/gutenberg/pull/46018/files#diff-93724b2f6e5dbf16c2b3c0efea57fa442b572f75f325d1cb185cf614b692cf9f
If I revert the changes made to the WP_HTML_Tag_Processor class in that PR, then PHPUnit tests pass.

Step-by-step reproduction instructions

  1. Install docker.
  2. Checkout Gutenberg; navigate to its directory.
  3. Add this line to the .wp-env.json file:
"phpVersion": "5.6",
  1. npm ci
  2. npm run build
  3. composer config platform.php 5.6
  4. composer remove spatie/phpunit-watcher --dev --no-update
  5. composer update
  6. npm run wp-env start
  7. npm run test:unit:php
  8. Observe failed tests in the console.

Screenshots, screen recording, code snippet

npm run wp-env run "tests-wordpress /var/www/html/wp-content/plugins/gutenberg/vendor/bin/phpunit -c /var/www/html/wp-content/plugins/gutenberg/phpunit.xml.dist --verbose"

> gutenberg@14.7.1 wp-env /src/wp-content/plugins/gutenberg
> wp-env "run" "tests-wordpress /var/www/html/wp-content/plugins/gutenberg/vendor/bin/phpunit -c /var/www/html/wp-content/plugins/gutenberg/phpunit.xml.dist --verbose"

[+] Running 1/0
 ⠿ Container f3a4f83488076060de4206c19ed1d495-tests-mysql-1  Running                                                                                                                                                                                                                                                                                                                                                     0.0s
⠋ Installing...
⠸ Running as single site... To run multisite, use -c tests/phpunit/multisite.xml
⠼ Not running ajax tests. To execute these, use --group ajax.
Not running ms-files tests. To execute these, use --group ms-files.
Not running external-http tests. To execute these, use --group external-http.
⠋ PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.39
Configuration: /var/www/html/wp-content/plugins/gutenberg/phpunit.xml.dist

⠧ .  63 / 743 (  8%)
⠸ .. 126 / 743 ( 16%)
⠼ ... 189 / 743 ( 25%)
............................................................... 252 / 743 ( 33%)
⠴ .......................................... 315 / 743 ( 42%)
............................................................... 378 / 743 ( 50%)
⠦ ...........................
Notice: Function wpdb::prepare was called <strong>incorrectly</strong>. Unsupported value type (object). Please see <a href="https://wordpress.org/support/article/debugging-in-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 4.8.2.) in /var/www/html/wp-includes/functions.php on line 5836

Notice: Function wpdb::prepare was called <strong>incorrectly</strong>. Unsupported value type (object). Please see <a href="https://wordpress.org/support/article/debugging-in-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 4.8.2.) in /var/www/html/wp-includes/functions.php on line 5836

Notice: Function wpdb::prepare was called <strong>incorrectly</strong>. Unsupported value type (object). Please see <a href="https://wordpress.org/support/article/debugging-in-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 4.8.2.) in /var/www/html/wp-includes/functions.php on line 5836

Notice: Function wpdb::prepare was called <strong>incorrectly</strong>. Unsupported value type (object). Please see <a href="https://wordpress.org/support/article/debugging-in-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 4.8.2.) in /var/www/html/wp-includes/functions.php on line 5836
⠴ II... 441 / 743 ( 59%)
⠴ ... 504 / 743 ( 67%)
⠇ .........................EEEE....... 567 / 743 ( 76%)
⠏ EEEE...................... 630 / 743 ( 84%)
⠙ ................... 693 / 743 ( 93%)
⠦ ..              743 / 743 (100%)

Time: 11.86 seconds, Memory: 37.25MB

There were 41 errors:

1) Render_Block_Heading_Test::test_block_core_heading_render_appends_css_class_to_a_vanilla_element with data set "should add a class name to a vanilla h2 element" ('<h2>Hello World</h2>', '<h2 class="wp-block-heading">...d</h2>')
⠧ strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/heading.php:37
/var/www/html/wp-content/plugins/gutenberg/phpunit/blocks/render-block-heading-test.php:22
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

2) Render_Block_Heading_Test::test_block_core_heading_render_appends_css_class_to_a_vanilla_element with data set "should add a class name even when the class attribute is already defined" ('<h2 class="is-align-right">He...d</h2>', '<h2 class="is-align-right wp-...d</h2>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/heading.php:37
/var/www/html/wp-content/plugins/gutenberg/phpunit/blocks/render-block-heading-test.php:22
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

3) Render_Block_Heading_Test::test_block_core_heading_render_appends_css_class_to_a_vanilla_element with data set "should handle single quotes" ('<h2 class='is-align-right'>He...d</h2>', '<h2 class="is-align-right wp-...d</h2>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/heading.php:37
/var/www/html/wp-content/plugins/gutenberg/phpunit/blocks/render-block-heading-test.php:22
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

4) Render_Block_Heading_Test::test_block_core_heading_render_appends_css_class_to_a_vanilla_element with data set "should handle single quotes with double quotes inside" ('<h2 class='" is-align-right'>...d</h2>', '<h2 class="&quot; is-align-ri...d</h2>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/heading.php:37
/var/www/html/wp-content/plugins/gutenberg/phpunit/blocks/render-block-heading-test.php:22
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

5) Render_Block_Heading_Test::test_block_core_heading_render_appends_css_class_to_a_vanilla_element with data set "should not add a class name even when it is already defined" ('<h2 class="is-align-right wp-...d</h2>', '<h2 class="is-align-right wp-...d</h2>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/heading.php:37
/var/www/html/wp-content/plugins/gutenberg/phpunit/blocks/render-block-heading-test.php:22
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

6) Render_Block_Heading_Test::test_block_core_heading_render_appends_css_class_to_a_vanilla_element with data set "should add a class name even when there are other HTML attributes present" ('<h2 style="display: block">He...d</h2>', '<h2 class="wp-block-heading" ...d</h2>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/heading.php:37
/var/www/html/wp-content/plugins/gutenberg/phpunit/blocks/render-block-heading-test.php:22
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

7) Render_Block_Heading_Test::test_block_core_heading_render_appends_css_class_to_a_vanilla_element with data set "should add a class name even when the class attribute is already defined and has many entries" ('<h2 class="is-align-right cus...d</h2>', '<h2 class="is-align-right cus...d</h2>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/heading.php:37
/var/www/html/wp-content/plugins/gutenberg/phpunit/blocks/render-block-heading-test.php:22
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

8) Render_Block_Heading_Test::test_block_core_heading_render_appends_css_class_to_a_vanilla_element with data set "should not add a class name to a nested h2" ('<h2 class="is-align-right cus...></h2>', '<h2 class="is-align-right cus...></h2>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/heading.php:37
/var/www/html/wp-content/plugins/gutenberg/phpunit/blocks/render-block-heading-test.php:22
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

9) Render_Block_Heading_Test::test_block_core_heading_render_appends_css_class_to_a_vanilla_element with data set "should not add a class name to a nested h2 when the parent has another attribute" ('<h2 style="display: block" cl...></h2>', '<h2 style="display: block" cl...></h2>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/heading.php:37
/var/www/html/wp-content/plugins/gutenberg/phpunit/blocks/render-block-heading-test.php:22
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

10) Render_Block_Heading_Test::test_block_core_heading_render_appends_css_class_to_a_vanilla_element with data set "should add a class name even when the class attribute is surrounded by other attributes" ('<h2 style="display: block" cl...></h2>', '<h2 style="display: block" cl...></h2>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/heading.php:37
/var/www/html/wp-content/plugins/gutenberg/phpunit/blocks/render-block-heading-test.php:22
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

11) Render_Block_Heading_Test::test_block_core_heading_render_appends_css_class_to_a_vanilla_element with data set "should add a class name without getting confused when there is a tricky data-class attribute present" ('<h2 data-class="corner case!"...></h2>', '<h2 data-class="corner case!"...></h2>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/heading.php:37
/var/www/html/wp-content/plugins/gutenberg/phpunit/blocks/render-block-heading-test.php:22
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

12) WP_HTML_Tag_Processor_Bookmark_Test::test_updates_bookmark_for_additions_after_both_sides
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-bookmark-test.php:257
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

13) WP_HTML_Tag_Processor_Bookmark_Test::test_updates_bookmark_for_additions_before_both_sides
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1324
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-bookmark-test.php:277
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

14) WP_HTML_Tag_Processor_Bookmark_Test::test_updates_bookmark_for_deletions_after_both_sides
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-bookmark-test.php:305
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

15) WP_HTML_Tag_Processor_Bookmark_Test::test_updates_bookmark_for_deletions_before_both_sides
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1324
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-bookmark-test.php:325
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

16) WP_HTML_Tag_Processor_Test::test_set_attribute_prevents_xss with data set #0 ('"')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:353
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

17) WP_HTML_Tag_Processor_Test::test_set_attribute_prevents_xss with data set #1 ('&quot;')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:353
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

18) WP_HTML_Tag_Processor_Test::test_set_attribute_prevents_xss with data set #2 ('&')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:353
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

19) WP_HTML_Tag_Processor_Test::test_set_attribute_prevents_xss with data set #3 ('&amp;')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:353
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

20) WP_HTML_Tag_Processor_Test::test_set_attribute_prevents_xss with data set #4 ('&euro;')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:353
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

21) WP_HTML_Tag_Processor_Test::test_set_attribute_prevents_xss with data set #5 (''')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:353
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

22) WP_HTML_Tag_Processor_Test::test_set_attribute_prevents_xss with data set #6 ('<>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:353
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

23) WP_HTML_Tag_Processor_Test::test_set_attribute_prevents_xss with data set #7 ('&quot";')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:353
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

24) WP_HTML_Tag_Processor_Test::test_set_attribute_prevents_xss with data set #8 ('" onclick="alert('1');"><span...cript>')
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:353
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

25) WP_HTML_Tag_Processor_Test::test_set_attribute_with_a_non_existing_attribute_adds_a_new_attribute_to_the_markup
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:386
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

26) WP_HTML_Tag_Processor_Test::test_update_first_when_duplicated_attribute
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:402
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

27) WP_HTML_Tag_Processor_Test::test_set_attribute_with_an_existing_attribute_name_updates_its_value_in_the_markup
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:415
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

28) WP_HTML_Tag_Processor_Test::test_remove_first_when_duplicated_attribute
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:452
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

29) WP_HTML_Tag_Processor_Test::test_remove_attribute_with_an_existing_attribute_name_removes_it_from_the_markup
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:465
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

30) WP_HTML_Tag_Processor_Test::test_add_class_creates_a_class_attribute_when_there_is_none
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:491
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

31) WP_HTML_Tag_Processor_Test::test_calling_add_class_twice_creates_a_class_attribute_with_both_class_names_when_there_is_no_class_attribute
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:505
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

32) WP_HTML_Tag_Processor_Test::test_remove_class_does_not_change_the_markup_when_there_is_no_class_attribute
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:518
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

33) WP_HTML_Tag_Processor_Test::test_add_class_appends_class_names_to_the_existing_class_attribute_when_one_already_exists
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:534
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

34) WP_HTML_Tag_Processor_Test::test_remove_class_removes_a_single_class_from_the_class_attribute_when_one_exists
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:550
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

35) WP_HTML_Tag_Processor_Test::test_calling_remove_class_with_all_listed_class_names_removes_the_existing_class_attribute_from_the_markup
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:567
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

36) WP_HTML_Tag_Processor_Test::test_add_class_does_not_add_duplicate_class_names
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:583
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

37) WP_HTML_Tag_Processor_Test::test_add_class_preserves_class_name_order_when_a_duplicate_class_name_is_added
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:599
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

38) WP_HTML_Tag_Processor_Test::test_add_class_when_there_is_a_class_attribute_with_excessive_whitespaces
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:617
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

39) WP_HTML_Tag_Processor_Test::test_remove_class_preserves_whitespaces_when_there_is_a_class_attribute_with_excessive_whitespaces
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:635
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

40) WP_HTML_Tag_Processor_Test::test_removing_all_classes_removes_the_existing_class_attribute_from_the_markup_even_when_excessive_whitespaces_are_present
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:654
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

41) WP_HTML_Tag_Processor_Test::test_set_attribute_takes_priority_over_add_class
strpos(): Offset not contained in string

/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:853
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:478
/var/www/html/wp-content/plugins/gutenberg/lib/experimental/html/class-wp-html-tag-processor.php:1661
/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:677
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

--

There were 34 failures:

1) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set "Invalid entity inside attribute value" ('<img src="https://s0.wp.com/i.../span>', '<img foo="bar" class="firstTa.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<img foo="bar" class="firstTag" src="https://s0.wp.com/i/atat.png" title="&; First &lt;title&gt; is &notit;" TITLE="second title" title="An Imperial &imperial; AT-AT"><span class="secondTag">test</span>
+<img class="firstTag" foo="bar" src="https://s0.wp.com/i/atat.png" title="&; First &lt;title&gt; is &notit;" TITLE="second title" title="An Imperial &imperial; AT-AT"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

2) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set "Single and double quotes in attribute value" ('<p title="Demonstrating how t.../span>', '<p foo="bar" class="firstTag".../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<p foo="bar" class="firstTag" title="Demonstrating how to use single quote (') and double quote (&quot;)"><span class="secondTag">test</span>
+<p class="firstTag" foo="bar" title="Demonstrating how to use single quote (') and double quote (&quot;)"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

3) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set "Unquoted attribute values" ('<hr a=1 a=2 a=3 a=5 /><span>t.../span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" a=1 a=2 a=3 a=5 /><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" a=1 a=2 a=3 a=5 /><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

4) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set "Double-quotes escaped in double-quote attribute value" ('<hr title="This is a &quot;do.../span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" title="This is a &quot;double-quote&quot;"><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" title="This is a &quot;double-quote&quot;"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

5) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set "Unquoted attribute value" ('<hr id=code><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" id=code><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" id=code><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

6) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set "Unquoted attribute value with tag-like value" ('<hr id=   <code> ><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" id=     <code> ><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" id=     <code> ><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

7) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set "Unquoted attribute value with tag-like value followed by tag-like data" ('<hr id=code>><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" id=code>><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" id=code>><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

8) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #0 ('<hr id=&quo;code><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" id=&quo;code><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" id=&quo;code><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

9) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #1 ('<hr id/test=5><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" id/test=5><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" id/test=5><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

10) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #2 ('<hr title="<hr>"><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" title="<hr>"><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" title="<hr>"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

11) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #3 ('<hr id=>code><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" id=>code><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" id=>code><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

12) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #4 ('<hr id"quo="test"><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" id"quo="test"><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" id"quo="test"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

13) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #5 (Binary String: 0x3c68722069640...0616e3e, Binary String: 0x3c687220666f6...0616e3e)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" idzero="test"><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" idzero="test"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

14) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #6 ('<hr >id="test"><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" >id="test"><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" >id="test"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

15) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #7 ('<hr =id="test"><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" =id="test"><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" =id="test"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

16) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #8 ('</><span>test</span>', '</><span foo="bar" class="fir.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-</><span foo="bar" class="firstTag">test</span>
+</><span class="firstTag" foo="bar">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

17) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #9 ('The applicative operator <* w.../span>', 'The applicative operator <* w.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-The applicative operator <* works well in Haskell; <data-tag foo="bar" class="firstTag"> is what?<span class="secondTag">test</span>
+The applicative operator <* works well in Haskell; <data-tag class="firstTag" foo="bar"> is what?<span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

18) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #10 ('<3 is a heart but <t3> is a t.../span>', '<3 is a heart but <t3 foo="ba.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<3 is a heart but <t3 foo="bar" class="firstTag"> is a tag.<span class="secondTag">test</span>
+<3 is a heart but <t3 class="firstTag" foo="bar"> is a tag.<span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

19) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #11 ('<?comment --><span>test</span>', '<?comment --><span foo="bar" .../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<?comment --><span foo="bar" class="firstTag">test</span>
+<?comment --><span class="firstTag" foo="bar">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

20) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #12 ('<!-- this is a comment. no <s.../span>', '<!-- this is a comment. no <s.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<!-- this is a comment. no <strong>tags</strong> allowed --><span foo="bar" class="firstTag">test</span>
+<!-- this is a comment. no <strong>tags</strong> allowed --><span class="firstTag" foo="bar">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

21) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #13 ('<![CDATA[This <is> a <strong .../span>', '<![CDATA[This <is> a <strong .../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<![CDATA[This <is> a <strong id="yes">HTML Tag</strong>]]><span foo="bar" class="firstTag">test</span>
+<![CDATA[This <is> a <strong id="yes">HTML Tag</strong>]]><span class="firstTag" foo="bar">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

22) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #14 ('<hr ===name="value"><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" ===name="value"><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" ===name="value"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

23) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #15 ('<hr asdf="test"><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" asdf="test"><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" asdf="test"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

24) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #16 ('<hr =asdf="tes"><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" =asdf="tes"><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" =asdf="tes"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

25) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #17 ('<hr ==="test"><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" ==="test"><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" ==="test"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

26) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #18 ('<hr =><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" =><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" =><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

27) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #19 ('<hr =5><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" =5><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" =5><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

28) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #20 ('<hr ==><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" ==><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" ==><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

29) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #21 ('<hr ===><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" ===><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" ===><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

30) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #22 ('<hr disabled><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" disabled><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" disabled><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

31) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #23 ('<hr a"sdf="test"><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" a"sdf="test"><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" a"sdf="test"><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

32) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set "Multiple unclosed tags treated as a single tag" ('                       <hr id=">"code\n                        <hr id=".../span>', '                   <hr foo="bar" class="first.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-                       <hr foo="bar" class="firstTag" id=">"code
+                       <hr class="firstTag" foo="bar" id=">"code
                        <hr id="value>"code
                        <hr id="/>"code
                        <hr id="value/>"code
                        />
                        <span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

33) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #24 ('<hr id   =5><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" id   =5><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" id   =5><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

34) WP_HTML_Tag_Processor_Test::test_updating_attributes_works_even_in_malformed_html_2 with data set #25 ('<hr id a  =5><span>test</span>', '<hr foo="bar" class="firstTag.../span>')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-<hr foo="bar" class="firstTag" id a  =5><span class="secondTag">test</span>
+<hr class="firstTag" foo="bar" id a  =5><span class="secondTag">test</span>

/var/www/html/wp-content/plugins/gutenberg/phpunit/html/wp-html-tag-processor-test.php:1117
phpvfscomposer:///var/www/html/wp-content/plugins/gutenberg/vendor/phpunit/phpunit/phpunit:51

Environment info

macOs 12.6

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@anton-vlasenko anton-vlasenko added the [Type] Bug An existing feature does not function as intended label Dec 15, 2022
@talldan
Copy link
Contributor

talldan commented Dec 16, 2022

cc @dmsnell @adamziel

@anton-vlasenko
Copy link
Contributor Author

anton-vlasenko commented Dec 16, 2022

PR: #46598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants