Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page List: "Customize this menu" change #46613

Closed
scruffian opened this issue Dec 16, 2022 · 4 comments
Closed

Page List: "Customize this menu" change #46613

scruffian opened this issue Dec 16, 2022 · 4 comments
Labels
[Block] Page List Affects the Page List Block

Comments

@scruffian
Copy link
Contributor

What problem does this address?

The page list block contains this panel:
Screenshot 2022-12-16 at 12 12 36

There are a few things about this that might need reconsidering:

  1. Should it be a panel? There’s no huge value in being able to collapse this thing, it could just be a heading.
  2. Is “Customize this menu” the right phrasing? It’s just a list of pages, it’s not a menu yet, and if we’re going to use the page list inside submenus, it might need different phrasing.
@scruffian scruffian added the [Block] Page List Affects the Page List Block label Dec 16, 2022
@carolinan
Copy link
Contributor

I think we can describe better what it actually does, which is convert it to link items (and submenu if there are child pages) in the navigation block.

@SaxonF
Copy link
Contributor

SaxonF commented Jan 12, 2023

Once #47064 is in place I'd argue this panel either isn't needed or should be moved to advanced as we can just infer the "customise/convert to link items" intent from any interaction of the list. We also have the existing "edit" action in the toolbar and in future could add more "transform to" options like list.

@scruffian
Copy link
Contributor Author

Let's move the panel lower in the inspector controls for now and revisit later.

@scruffian
Copy link
Contributor Author

This is already captured in #47236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Page List Affects the Page List Block
Projects
None yet
Development

No branches or pull requests

3 participants