Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Components, settle on 40px and 32px "small" sizes. #46734

Closed
jasmussen opened this issue Dec 22, 2022 · 4 comments
Closed

UI Components, settle on 40px and 32px "small" sizes. #46734

jasmussen opened this issue Dec 22, 2022 · 4 comments
Labels
Design System Issues related to the system of combining components according to best practices. [Feature] Component System WordPress component system [Feature] UI Components Impacts or related to the UI component system Figma Component Issues that require updates to Figma components for designers Needs Dev Ready for, and needs developer efforts Needs Figma Update Needs an update to Figma for design purposes [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

jasmussen commented Dec 22, 2022

UI components across the editor (input fields, buttons, etc.) are currently a range of sizes, between 32px, 36px, and 40px:

Screenshot 2022-12-22 at 11 21 06 Screenshot 2022-12-22 at 11 20 59
The inserter button is 32x32, the other buttons are 36x36 Buttons here are 36px, including the toggles
Screenshot 2022-12-22 at 11 24 03 Screenshot 2022-12-22 at 11 21 12
Toggle buttons in the block toolbar are 32x32 Inspector controls are standardizing on 40px

There's an opportunity here to standardize and make consistent the controls, so there's less guesswork as to which dimensions controls should have. We could do this:

  • All controls (inputs, segmented controls, sliders, dropdowns, and buttons) are 40px by default.
  • All toggles (block toolbar button, toggles in the inspector such as quick transforms, the active state inside a segmented control) are 32x32px.
  • The Button component has a 32px small version, to be used when the button is used in context of toggles, such as the top toolbar.
  • The 36px size is retired entirely.

Here's a grid of metrics to illustrate how this could work:

grid

Both 32 and 40px are base8 friendly, which would simplify the grid system. And with a single default (40px for controls, 32 for toggles inside), there would be no guesswork as to which size to use. The 32px button size would be the exception to use, as noted, in the top toolbar for buttons.

@jasmussen jasmussen added Needs Design Feedback Needs general design feedback. [Feature] UI Components Impacts or related to the UI component system Needs Figma Update Needs an update to Figma for design purposes [Feature] Component System WordPress component system Figma Component Issues that require updates to Figma components for designers labels Dec 22, 2022
@mirka
Copy link
Member

mirka commented Dec 22, 2022

I'm very happy to see this! We'll start working out the technical logistics in #46741.

@annezazu annezazu moved this to 🎨 Needs design in Gutenberg Phase 2: Customization Mar 22, 2023
@annezazu annezazu added this to Polish Apr 28, 2023
@priethor priethor moved this to 💻 Needs development in Polish Apr 28, 2023
@annezazu annezazu removed this from Polish May 1, 2023
@jasmussen jasmussen added the Design System Issues related to the system of combining components according to best practices. label Sep 24, 2024
@auareyou auareyou moved this to Inbox 📥 in Design systems — Backlog Oct 7, 2024
@jasmussen
Copy link
Contributor Author

I wonder if we can close this one as fixed?

@mirka
Copy link
Member

mirka commented Dec 19, 2024

Sure. Closing in favor of the following tracking issues, where there are just a few more things we're working on:

@mirka mirka closed this as completed Dec 19, 2024
@github-project-automation github-project-automation bot moved this from 💻 Needs development to ✅ Done in Gutenberg Phase 2: Customization Dec 19, 2024
@github-project-automation github-project-automation bot moved this from 🔦 Needs triage to 💫 Done in Design systems — Backlog Dec 19, 2024
@jasmussen
Copy link
Contributor Author

Thanks for all the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System Issues related to the system of combining components according to best practices. [Feature] Component System WordPress component system [Feature] UI Components Impacts or related to the UI component system Figma Component Issues that require updates to Figma components for designers Needs Dev Ready for, and needs developer efforts Needs Figma Update Needs an update to Figma for design purposes [Type] Enhancement A suggestion for improvement.
Projects
Status: 💫 Done
Status: Done
Development

No branches or pull requests

3 participants