Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent link options & handling between Image Blocks and Inline Images #48150

Open
XVII opened this issue Feb 17, 2023 · 3 comments
Open

Inconsistent link options & handling between Image Blocks and Inline Images #48150

XVII opened this issue Feb 17, 2023 · 3 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Dev Ready for, and needs developer efforts [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement.

Comments

@XVII
Copy link

XVII commented Feb 17, 2023

What problem does this address?

The Link icon, options & behaviours are different for Image Blocks vs. Inline Images.
This is confusing for users as they're both images and should be treated similarly.

Even the icon for Link is different. How confusing.

Image Block Link options are:

image

Inline Image Link options are:

image

What is your proposed solution?

Make them consistent.
The Inline Image Link options should mirror the Image Block link options. It should also respect the same defaults and settings.
This was referenced Feb 17, 2023
Open
Open
@mrfoxtalbot mrfoxtalbot added [Type] Enhancement A suggestion for improvement. [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Feb 20, 2023
@ellatrix
Copy link
Member

@getdave I believe you have worked on the link UI? Or do you know who has recently?

@getdave
Copy link
Contributor

getdave commented Jul 27, 2023

Oh just a bit! 😅 Thanks for the ping.

Luckily myself and @richtabor are doing a deep dive on these issues and looking to resolve them as part of #50891.

@richtabor
Copy link
Member

Related (covers media linking): #50893

@annezazu annezazu mentioned this issue Aug 3, 2023
Closed
42 tasks
@annezazu annezazu added the Needs Dev Ready for, and needs developer efforts label Aug 3, 2023
@ellatrix ellatrix added the [Package] Format library /packages/format-library label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Dev Ready for, and needs developer efforts [Package] Format library /packages/format-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@getdave @XVII @richtabor @mrfoxtalbot @ellatrix @annezazu