Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor Navigation panel: When the 'main' navigation menu changes, it's not always clear why, and can be confusing #48690

Closed
jameskoster opened this issue Mar 2, 2023 · 3 comments · Fixed by #48689
Labels
[Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback.

Comments

@jameskoster
Copy link
Contributor

The Navigation panel is supposed to detail the website's main navigation menu. The problem is that the menu that appears in this panel can sometimes change, and it's not always obvious why it does so which can lead to confusion.

Here's the current logic for determining the 'main' menu.

the navigation referenced by the first nav block in the template

This part seems to be causing issues. Example:

I want to add some social icons at the very top of my site. I create a new menu for this in my Header template part:

Screenshot 2023-03-02 at 13 01 11

After saving, I now find that menu represented in the Navigation panel:

Screenshot 2023-03-02 at 13 01 48

This is unexpected, and it seems nonsensical for this menu to be given such prominence.

the navigation manually selected by the user in the navigation block inspector
when a navigation block gets inspected within the canvas

This part is also a bit problematic. I don't think that merely interacting with a Navigation menu should subsequently mark it as the 'main' one.


What's the solution? It would likely make the Navigation panel feel more robust if we simply said that the first menu created is the 'main' one. This would replace the default 'Page list' menu that exists before no menus have been created.

As a bonus point it would be nice to mark this menu somehow in popovers like this one:

Screenshot 2023-03-02 at 13 13 14

It may be as simple as adding a (main) suffix.

Screenshot 2023-03-02 at 13 16 19

@jameskoster jameskoster added [Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 2, 2023
@bobbingwide
Copy link
Contributor

What's the solution? It would likely make the Navigation panel feel more robust if we simply said that the first menu created is the 'main' one. This would replace the default 'Page list' menu that exists before no menus have been created.

The fix in #48689 says the opposite.

Always pick the latest published manu (sic).

See also #48897 & #48891

@annezazu
Copy link
Contributor

In the flurry of work done around the Navigation section for 6.2 and the later removal, this issue was previously closed. However, it was closed thanks to a PR focused on updating the logic of what's shown rather than thinking about the entire UX, which remains confusing without an option to change what appears built into the sidebar. As a result, I'm going to re-open this as I believe this remains an area to iterate on, even if it's just connecting dots in the UI like James mentions above.

@annezazu annezazu reopened this Apr 23, 2023
@annezazu annezazu added the Needs Design Feedback Needs general design feedback. label Apr 23, 2023
@annezazu annezazu moved this to 🎨 Needs design in Gutenberg Phase 2: Customization Apr 23, 2023
@scruffian
Copy link
Contributor

With all the work that's been done on the navigation in Site View, we can now close this.

@github-project-automation github-project-automation bot moved this from 🎨 Needs design to ✅ Done in Gutenberg Phase 2: Customization Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback.
Projects
Status: Done
4 participants