Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting a Columns block into a reusable block fails #4923

Closed
mtias opened this issue Feb 7, 2018 · 3 comments
Closed

Converting a Columns block into a reusable block fails #4923

mtias opened this issue Feb 7, 2018 · 3 comments
Assignees
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended

Comments

@mtias
Copy link
Member

mtias commented Feb 7, 2018

Steps

  • Create a Columns block.
  • Add some blocks to the columns.
  • Convert to reusable block.

Result

image

@mtias mtias added [Type] Bug An existing feature does not function as intended [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) labels Feb 7, 2018
@aduth aduth self-assigned this Feb 9, 2018
@mcsf
Copy link
Contributor

mcsf commented Feb 15, 2018

While a proper fix (#5010) is readied, #5044 disables conversion of Columns blocks (v2.2).

@aduth
Copy link
Member

aduth commented Feb 16, 2018

Noting that I started work on an alternative approach which includes a total refactor of reusable blocks to behave as pointers to original blocks. The main issue is that since reusable blocks load after-the-fact, there needs to be reconciliation in blocks state to (a) receive those blocks and (b) not mark the post as dirty. This is tricky, and I'm considering whether it could be sensible to share the reducer logic itself between normal blocks and reusable blocks, but still track reusable blocks in a separate part of state (e.g. a reducer creator).

@aduth
Copy link
Member

aduth commented Mar 20, 2018

Closed by #5228

@aduth aduth closed this as completed Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants