Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: Endless scrolling in zoom out and style views when there are blocks with vh units #49299

Closed
t-hamano opened this issue Mar 23, 2023 · 4 comments
Closed

Site Editor: Endless scrolling in zoom out and style views when there are blocks with vh units #49299

t-hamano opened this issue Mar 23, 2023 · 4 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Mar 23, 2023 •
edited
Loading

Might be related to this comment

Description

If the content contains blocks with a height in units of vh, there will be endless scrolling in both the zoomed-out and style views. This problem occurs when the block has a large value, such as 100vh high. iframe editor content will infinitely grow in height.

Step-by-step reproduction instructions

  • Activate "Zoomed out view" from the Gutenberg > Experiments menu.
  • Open the site editor.
  • Insert a group block in one of the templates.
  • Set min.Height to 100vh from the Dimensions panel.
  • Click the "zoom out" view button or access "Browse styles" menu.

Screenshots, screen recording, code snippet

d8f6da30a7404200ff8ae99e2443987c.mp4

Environment info

  • WordPress Version: 6.3-alpha-55582
  • Gutenberg Version: Latest trunk (15.4.0)

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@t-hamano t-hamano added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Mar 23, 2023
@Mamaduka
Copy link
Member

We fixed a similar bug for Block Previews in WP 5.9. See #38175.

@richtabor richtabor mentioned this issue May 8, 2023
Open
@richtabor
Copy link
Member

Sharing that I'm also seeing this:

CleanShot.2023-05-08.at.17.09.49.mp4

@richtabor richtabor added the [Type] Bug An existing feature does not function as intended label May 8, 2023
@t-hamano t-hamano mentioned this issue Jul 6, 2023
Closed
@t-hamano t-hamano mentioned this issue Dec 28, 2023
Closed
@MaggieCabrera
Copy link
Contributor

Should be fixed by #59334, can you still reproduce?

@t-hamano
Copy link
Contributor Author

I've confirmed that this issue has been fixed intrunk, so I'm closing it.

902a675079c7a602d96d8e3a6bd41ca8.mp4

@stokesman stokesman mentioned this issue Jul 11, 2024
Draft
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 11, 2024
@stokesman stokesman removed their assignment Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Mamaduka @richtabor @MaggieCabrera @stokesman @t-hamano