Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Style Book in Styles details view #50393

Closed
Tracked by #33094
mtias opened this issue May 5, 2023 · 7 comments · Fixed by #50566
Closed
Tracked by #33094

Expose Style Book in Styles details view #50393

mtias opened this issue May 5, 2023 · 7 comments · Fixed by #50566
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented May 5, 2023

Let's add a control to easily dive into the Style Book from the Site Editor > Styles panel.

Visual

CleanShot 2023-05-05 at 18 23 08

Added by @richtabor for feedback.
@mtias mtias added the Needs Design Needs design efforts. label May 5, 2023
@richtabor richtabor added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels May 5, 2023
@richtabor richtabor moved this to Needs feedback in 6.3 Design May 5, 2023
@richtabor richtabor added this to Polish May 5, 2023
@richtabor richtabor moved this to Needs design in Polish May 5, 2023
@jasmussen
Copy link
Contributor

The eye seems the easiest starting point, and does not preclude future changes, so I think we should start with that.

The "Styles" section, I could see in the future, containing other options, such as font sets, or even high level color palette switching. That's something to be explored, but if that were the case we'd need another detail page before you get to style variations like we have now. In such a context, we could consider the style book being a menu item. Even then, so long as the style book lives inside the fullscreen view, its context near the edit button seems useful.

@jasmussen jasmussen added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels May 8, 2023
@jasmussen jasmussen moved this from Needs feedback to Needs dev in 6.3 Design May 8, 2023
@jasmussen jasmussen moved this from Needs design to Needs development in Polish May 8, 2023
@mtias mtias mentioned this issue May 8, 2023
57 tasks
@richtabor
Copy link
Member

In such a context, we could consider the style book being a menu item. Even then, so long as the style book lives inside the fullscreen view, its context near the edit button seems useful.

I'm thinking the same. 👌

@annezazu
Copy link
Contributor

annezazu commented May 8, 2023

Curious how we can, in adding the Style Book here, also ensure the Style settings open up properly when selecting on individual items:

style.book.mov

This is a high impact part of the Style Book implementation right now and I could see this being a jarring flow currently if it dropped you out of the Site View and into the Edit View with the Style settings open.

@richtabor richtabor mentioned this issue May 8, 2023
3 tasks
@richtabor
Copy link
Member

ensure the Style settings open up properly when selecting on individual items

This was resolved recently in #49350 I think.

@annezazu
Copy link
Contributor

annezazu commented May 8, 2023

Exactly! I'm saying that's a high impact feature to ensure works intuitively in this experience too. Right now, I think it would be pretty jarring to go to Design > Styles > Open Style Book and click on a block only to have you moved out of the Site View and into the Edit View with Styles open.

@richtabor
Copy link
Member

Design > Styles > Open Style Book

I think this action would invoke Style Book entirely, bringing you into Edit View with Styles open and triggering Style Book. Just like how the "Edit" brings you into the Edit View, with Global Styles open.

@andrewserong andrewserong self-assigned this May 12, 2023
@andrewserong andrewserong added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement. labels May 12, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 12, 2023
@andrewserong
Copy link
Contributor

I've had a go at this one over in #50566

@priethor priethor moved this from Needs development to In progress in Polish May 12, 2023
@annezazu annezazu moved this to 💻 Needs development in Gutenberg Phase 2: Customization May 15, 2023
@annezazu annezazu removed this from Polish May 15, 2023
@github-project-automation github-project-automation bot moved this from 💻 Needs development to ✅ Done in Gutenberg Phase 2: Customization May 17, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 22, 2023
@jameskoster jameskoster moved this from Needs dev to Done in 6.3 Design Jun 7, 2023
@priethor priethor removed the Needs Dev Ready for, and needs developer efforts label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants