Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't Arrow Up into empty Columns Block #51554

Closed
jeryj opened this issue Jun 15, 2023 · 2 comments · Fixed by #55197
Closed

Can't Arrow Up into empty Columns Block #51554

jeryj opened this issue Jun 15, 2023 · 2 comments · Fixed by #55197
Assignees
@ellatrix
Labels
[Block] Columns Affects the Columns Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jeryj
Copy link
Contributor

jeryj commented Jun 15, 2023

The column block won't allow an arrow up keypress to navigate into an empty column block.

Debugging this, it seems like the arrow key navigation code is all working correctly. It's correctly identifying the appender button as the one to focus, but it's unable to focus it.

Reproduction

  • Add a column block
  • Add a paragraph or any block after it
  • Try to arrow up from the paragraph block into the column block

Video

Screen.Recording.2023-06-15.at.3.46.31.PM.mov
@jeryj jeryj added [Block] Columns Affects the Columns Block [a11y] Keyboard & Focus labels Jun 15, 2023
@jordesign jordesign added the [Type] Bug An existing feature does not function as intended label Jul 18, 2023
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Keyboard & Focus labels Jul 24, 2023
@ellatrix ellatrix added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Aug 18, 2023
@andrewserong andrewserong mentioned this issue Oct 10, 2023
Closed
@andrewserong
Copy link
Contributor

Just linking a potentially similar writing flow issue: #55177

@annezazu annezazu mentioned this issue Oct 10, 2023
Closed
42 tasks
@ellatrix ellatrix mentioned this issue Oct 10, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 10, 2023
@ellatrix
Copy link
Member

It's not a writing flow issues, but a CSS issues due to the use of visibility: none. Fixed in #55197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellatrix ellatrix

Labels
[Block] Columns Affects the Columns Block [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Columns block: fix arrow up into it WordPress/gutenberg
5 participants
@jeryj @jordesign @ellatrix @andrewserong @priethor