Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles revisions: revision comparisons #53620

Closed
ramonjd opened this issue Aug 14, 2023 · 3 comments
Closed

Global styles revisions: revision comparisons #53620

ramonjd opened this issue Aug 14, 2023 · 3 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. Needs Technical Feedback Needs testing from a developer perspective. [Type] Enhancement A suggestion for improvement.

Comments

@ramonjd
Copy link
Member

ramonjd commented Aug 14, 2023

What problem does this address?

It's possible to use WordPress's existing revisions.php page to compare the global styles custom post, however it means comparing changes to JSON, which may not be accessible to everyone.

Screenshot 2023-07-24 at 15 56 22

It would be more useful to have a visual tool, or initially, a text summary of changes, to differentiate global styles revisions.

Discussed in:

What is your proposed solution?

Ideally we'd have a visual representation of changes between two revisions. @jameskoster has been thinking about this:

As mentioned previously, it is possible to load two versions in two iframes:

2023-05-01.16.16.51.mp4

@c4rl0sbr4v0 has also explored a comparison engine to diff two theme.json trees: tenberg/pull/52829#issuecomment-1659027089

We probably need to undertake more investigation in order to balance performance and utility.

As a starting taster will might like to display top-level changes to the user, e.g.,

@ramonjd ramonjd added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. Needs Technical Feedback Needs testing from a developer perspective. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Aug 14, 2023
@jameskoster
Copy link
Contributor

@ramonjd would you say this is duplicative of #53484? (Feel free to edit that issue to add more flavour).

@ramonjd
Copy link
Member Author

ramonjd commented Aug 15, 2023

would you say this is duplicative of #53484? (Feel free to edit that issue to add more flavour).

Definitely! I'll move some of the info over to that one. Thanks for the heads up.

@ramonjd
Copy link
Member Author

ramonjd commented Aug 15, 2023

Closing in favour of #53484

@ramonjd ramonjd closed this as completed Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. Needs Technical Feedback Needs testing from a developer perspective. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants