Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles Revisions: revision history overview is difficult to access #55486

Closed
HeikoMamerow opened this issue Oct 19, 2023 · 10 comments
Closed
Labels
[Feature] History History, undo, redo, revisions, autosave. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@HeikoMamerow
Copy link

What problem does this address?

The revision history overview is difficult to access. The history is only accessible via an unnecessary intermediate step.

By clicking on the image button this unnecessary overview appears:
Gutenberg-revisions-step1

... You then still have to click on "Revision history" to finally see the history:
Gutenberg-revisions-step2

What is your proposed solution?

By clicking on the image button, the history overview should be displayed directly.

@colorful-tones colorful-tones added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] History History, undo, redo, revisions, autosave. labels Oct 19, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Oct 19, 2023
@ramonjd ramonjd added the Needs Design Feedback Needs general design feedback. label Oct 24, 2023
@ramonjd
Copy link
Member

ramonjd commented Oct 24, 2023

Thanks for creating this issue.

Retaining "Reset to defaults" was a deliberate measure in #51318, which consolidated these buttons to remove a bit of clutter in styles actions bar. This is despite the "Default styles" entry at the end of the revisions list.

The "Reset to defaults" in the drop down still provides quick access to reverting global styles changes, particularly where the revisions list is long and the "Default styles" revision is buried at the bottom of the list.

Furthermore, there are plans to allow n revisions with pagination (See #53621), so I think it might be desirable for now to retain the reset button.

I think, however, there could be scope to use the idea in this issue and move the "Reset" button to a more prominent position in the revisions view itself.

cc @jameskoster for thoughts

@jameskoster
Copy link
Contributor

I could go either way on this one to be honest.

Given that resetting to defaults is a fairly infrequent action(?), and that similar links (e.g. posts) take you directly to the revisions UI (where you can reset to default), I could see this button opening the revisions panel rather than a dropdown.

This change could make the revisions button a toggle too, which would probably work a bit better than the current experience—it's a bit strange how you can open the revisions dropdown when you're already in the Revisions panel.

All that said, it would make resetting more arduous, particularly when there are multiple pages of revisions as Ramon pointed out.

I'd be interested to hear other designers thoughts on this one cc @WordPress/gutenberg-design

@ramonjd
Copy link
Member

ramonjd commented Oct 25, 2023

Thanks for the thoughts. Happy to follow up on any proposals 🙇🏻

If the reset functionality doesn't need to be prominent, what about have a reset button somewhere on the main style panels, like at the bottom? It's bit ambiguous in relation to what we're resetting though, e.g., whether "Additional CSS" is also reset.

Screenshot 2023-10-25 at 2 41 12 pm

it's a bit strange how you can open the revisions dropdown when you're already in the Revisions panel.

Very true! I have a teeny PR to disable the menu item over in:

@richtabor
Copy link
Member

If the reset functionality doesn't need to be prominent, what about have a reset button somewhere on the main style panels, like at the bottom?

I think that's much too prominent.

@t-hamano
Copy link
Contributor

Regarding the reset button location, I suggested one approach in this comment.

Another approach is to move only the reset button back to the ellipsis menu. And the revision button is a button that toggles the revision panel directly and does not display a popover.

reset-to-defaults

@ramonjd
Copy link
Member

ramonjd commented Oct 26, 2023

I closed #55620 pending further discussion. I believe others are thinking about this in a more holistic manner cc @apeatling

@apeatling
Copy link
Contributor

Tracking more holistic changes here #55776

@ramonjd
Copy link
Member

ramonjd commented Dec 5, 2023

By clicking on the image button, the history overview should be displayed directly.

I think the following PR closes this issue, no?

@t-hamano
Copy link
Contributor

t-hamano commented Dec 5, 2023

I also think this issue has been resolved by #56454, so I would like to close it.

Revisions can be opened and closed in one click from the Global Styles panel, and we can still access the Reset Styles menu.

d7e5b564bde51b25b269a0bab68b8635.mp4

@t-hamano t-hamano closed this as completed Dec 5, 2023
@apeatling
Copy link
Contributor

Thanks for catching this one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

8 participants