Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract getNodeText and add Unit Tests #55495

Open
jeryj opened this issue Oct 19, 2023 · 5 comments
Open

Extract getNodeText and add Unit Tests #55495

jeryj opened this issue Oct 19, 2023 · 5 comments
Assignees
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Code Quality Issues or PRs that relate to code quality

Comments

@jeryj
Copy link
Contributor

jeryj commented Oct 19, 2023

We needed to get an accessibility fix in to resolve (#47767) before the release. Given it was such a short timeline, having the fix be beta tested more was more important than this refactor. As a follow-up, there's some refactoring we could do to improve the getNodeText implementation from #54902

  1. Extract it to its own file
  2. Add unit tests to verify the correct functionality
  3. Refactor it to remove code that won't be run.
@jeryj jeryj added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Code Quality Issues or PRs that relate to code quality labels Oct 19, 2023
@alexstine
Copy link
Contributor

#54902 (comment)

@alexstine alexstine self-assigned this Oct 19, 2023
@sreeragdas
Copy link

@alexstine , i am interested in working , can u pls share me the details

@alexstine
Copy link
Contributor

@sreeragdas All details are in the description above. Essentially, we need to move that helper function to a new file and write unit tests around it to prevent regressions. Thanks.

@oceantober
Copy link

Hello! My team of 3 beginner students from Code Day would like to work on this issue!

@alexstine
Copy link
Contributor

@oceantober Sure, have them open a PR. Happy to review their work. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

No branches or pull requests

4 participants