Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor Templates: Translations strings ignore user settings #55699

Open
hanneslsm opened this issue Oct 30, 2023 · 4 comments
Open

Site Editor Templates: Translations strings ignore user settings #55699

hanneslsm opened this issue Oct 30, 2023 · 4 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended

Comments

@hanneslsm
Copy link

Description

The global site language of one of my site is German.
My user has english as its default language.
The template names are translated to German, even though I'd expect it to be english.

Step-by-step reproduction instructions

  1. Change the site language to any language, e.g. German
  2. Change the language of the user settings to another language, e.g. english
  3. See two languages mixed in the site editor > templates

Screenshots, screen recording, code snippet

Screen.Recording.2023-10-30.at.13.37.13.mov

Environment info

  • WP 6.3.2
  • GB 16.9.0

Please confirm that you have searched existing issues in the repo.

No

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@hanneslsm hanneslsm changed the title Site Editor Templates: Translations Site Editor Templates: Translations strings ignore user settings Oct 30, 2023
@Mamaduka Mamaduka added Internationalization (i18n) Issues or PRs related to internationalization efforts [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Oct 30, 2023
@jordesign jordesign added [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. labels Oct 31, 2023
@mt8
Copy link

mt8 commented Nov 1, 2023

I tested this issue. I reproduced it with the code from the trunk branch.

I tested it with the site settings set to English and the user settings set to Japanese.
In that case, the site editor's "templates" started with a mix of Japanese and English.

スクリーンショット 2023-11-02 2 36 27

@mt8
Copy link

mt8 commented Nov 1, 2023

The template names that are translated seem to be only templates added from customTemplates in theme.json of the enabled theme (Twenty Twenty-Three in my environment).

https://themes.trac.wordpress.org/browser/twentytwentythree/1.2/theme.json#L4

@hanneslsm
Copy link
Author

Thanks for testing!

The template names that are translated seem to be only templates added from customTemplates in theme.json of the enabled theme (Twenty Twenty-Three in my environment).

I think the default page template titles are getting translated. Related: #51428

Copy link

github-actions bot commented Dec 3, 2023

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants