Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing Cancel while editing a reusable block does not reset the block preview #5719

Closed
noisysocks opened this issue Mar 20, 2018 · 0 comments · Fixed by #5723
Closed

Pressing Cancel while editing a reusable block does not reset the block preview #5719

noisysocks opened this issue Mar 20, 2018 · 0 comments · Fixed by #5723
Assignees
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

Issue Overview

Pressing Cancel while editing a reusable block should discard any unsaved changes that have been made to that block.

Steps to Reproduce (for bugs)

  1. Insert a reusable block
  2. Select it and click Edit
  3. Make some changes to the block
  4. Click Cancel

Expected Behavior

The block should return to how it looked before Edit was clicked.

Current Behavior

The block retains the changes made in step 3, which does not reflect how the post will look once published or previewed.

Possible Solution

The changes to the referenced block's attributes should be kept in local state until Save is clicked, i.e. revert this recent change.

Screenshots / Video

regression

Related Issues and/or PRs

This regression was introduced by #5228.

@noisysocks noisysocks added the [Type] Bug An existing feature does not function as intended label Mar 20, 2018
@noisysocks noisysocks self-assigned this Mar 20, 2018
@noisysocks noisysocks added the [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) label Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant