Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block mover controls have a low contrast ratio #587

Closed
nylen opened this issue May 1, 2017 · 2 comments
Closed

Block mover controls have a low contrast ratio #587

nylen opened this issue May 1, 2017 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@nylen
Copy link
Member

nylen commented May 1, 2017

The controls to move a block up and down are currently this color:

$light-gray-600: #d7dade;

This has a contrast ratio of 1.4 against white:

2017-05-01t11 55 12-0500

The minimum contrast ratio according to WCAG 2.0 is 4.5:
@nylen nylen added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Framework Issues related to broader framework topics, especially as it relates to javascript labels May 1, 2017
This was referenced May 1, 2017
Merged
Closed
@afercia
Copy link
Contributor

afercia commented May 1, 2017

Just as a note (also for #573) disabled controls don't need to meet the requirement so the disabled block mover button can have a contrast ratio lower than 4.5:1.

@mtias mtias added [Feature] Blocks Overall functionality of blocks and removed Framework Issues related to broader framework topics, especially as it relates to javascript labels May 3, 2017
@nylen
Copy link
Member Author

nylen commented Jun 9, 2017

This appears to have been resolved by #981.

@nylen nylen closed this as completed Jun 9, 2017
@nylen nylen mentioned this issue Jun 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nylen @mtias @afercia