Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor > Patterns: Consider adding a "Add new pattern" button #59099

Closed
annezazu opened this issue Feb 15, 2024 · 4 comments · Fixed by #60302
Closed

Site Editor > Patterns: Consider adding a "Add new pattern" button #59099

annezazu opened this issue Feb 15, 2024 · 4 comments · Fixed by #60302
Assignees
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

In watching some folks test the new Data Views for 6.5, one of the participants mentioned how hard it is to figure out how to create your own patterns with the + button being so easy to miss. When compared to the other sections, it stands out even more as the Patterns section shows all patterns but doesn't have that ever present "Add new ____" button clearly placed. This feels odd considering patterns are likely something someone will build more than new templates. We want folks to use these and they aren't meant to be overly advanced! Here's a snapshot:

Site Editor > Templates > Manage all templates:

Screenshot 2024-02-15 at 9 42 17 AM

Site Editor > Patterns
Screenshot 2024-02-15 at 9 42 33 AM

Site Editor > Patterns > Manage all template parts

Screenshot 2024-02-15 at 9 51 03 AM

Site Editor > Pages > Manage all pages
Screenshot 2024-02-15 at 9 42 06 AM

How can we improve this?

My brain goes in a few directions:

  • Add a "Add new pattern" to each section of patterns. We'd have to decide if you're in the "Banner" category if clicking "Add new" would automatically add that as a category or if each were distinct ("my patterns" would have to be no category since it isn't tied to one).
  • Add "Add a new pattern" after someone adds an initial pattern under just the "my patterns" section and "all patterns" (or just one section). This would at least tie the action to creating your own pattern but doesn't seem great nor consistent. I could see it feeling like something you're stumbling on and it stands in contrast to what we do in other sections.

Something else entirely :) @WordPress/gutenberg-design as I imagine this was an intentional decision.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 15, 2024
@jameskoster
Copy link
Contributor

This was originally noted in #58198. Perhaps @ntsekouras has a moment to look into the feasibility?

@richtabor
Copy link
Member

Would we not use the + in the dark material? That seems more connective/existing. Why'd we opt for the big button on the right, rather than leverage the existing +?

@jameskoster
Copy link
Contributor

In data views, the sidebar primarily serves for navigation and managing views. Some data views may not require additional or custom views, thus lacking a dedicated drilldown. Without a drilldown, where would the '+' button live?

Screenshot 2024-02-19 at 14 14 07

@SaxonF
Copy link
Contributor

SaxonF commented Feb 20, 2024

What @jameskoster said. Would be nice to start establishing this standard pattern of title on left and CTA's on right when it comes to page content. Actions in sidebar can relate to whatever is in the sidebar, in the case of data views its "views".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants