Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data views: Add loading indicator for preview field #59832

Open
jameskoster opened this issue Mar 13, 2024 · 1 comment
Open

Data views: Add loading indicator for preview field #59832

jameskoster opened this issue Mar 13, 2024 · 1 comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Related: #59792

Here's Table layout:

preview.mp4

It feels very clunky how the templates load piecemeal. It's particularly bad in this layout due to the reflow that occurs when the templates load.

Here's Grid layout:

grid.mp4

The fixed height helps a bit by eliminating the reflow, but it still feels very sluggish.


To address we can add a fixed height to the template previews in table layout, and add a loading indicator which obscures the preview until fully loaded.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Mar 13, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 6, 2024
@t-hamano
Copy link
Contributor

I tried solving it once in #61408, but it wasn't the ideal approach. let me remove myself from assignees as I can't think of any other solution at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Status: Next
Status: 🏈 Punted to 6.7
Development

Successfully merging a pull request may close this issue.

2 participants