-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages data view: Clarify 'Date' field #60477
Comments
This'll take some finessing, but it might be hard to not have to need two lines of text there. It might be good to gather a bit of comparison material across other apps that have similar formats, see what standards there are. |
I don't know that it needs to involve two lines. The prefix could be a single word: |
That said...
I think this could be worth discussing. Filtering by publish date (a legitimate use case) is very different to filtering by modified date (still legitimate, but probably less common?). |
You'd only ever see Published or Modified, in the existing pages, right? That would simplify things, and maintain the value as well as the density. Building on your suggestion but using the existing date format, this isn't bad:
Mainly wondering, could we/should we make an effort to ensure the dates line up vertically, even if the prefix varies in width? |
Also "Scheduled".
Yeah that's a bit tricky. We might have to choose between vertically aligned dates or separate lines. Another option could be to use a 'human friendly' date format e.g. "Published 30 minutes ago" which might mitigate the alignment issue? The actual timestamp could appear in a tooltip on hover if required. |
I have no strong opinion about this, but if we feel like both modified and published dates have value, we should probably have them as separate fields. That would probably help with the filtering (when we have date filters). Additionally if we render both dates in a single field (two lines), I guess in some of them we'll only have one and I'm not sure if this affects the design for any reason. An example is draft posts will always have only modified date. |
I'd tend to reach parity first, and then expand beyond that when we know it's necessary. This is a cat that's hard to put back in the bag. Easy to expand, hard to contract. |
Agreed. For now let's mimic wp-admin, IE add the prefix. We can follow-up to discuss in more detail the addition of a separate 'modified date' field. |
Does that mean just change the label from |
@ntsekouras no, because we need to capture modified dates for drafts. So for now it means adding a prefix to the field value. I added a screenshot to the OP. |
I'm giving this one a shot. |
PR at #61709 |
Here's how the Date field looks in the Pages data view:
It's not clear which date is being referred to. Specifically; is it the publish date, the modified date, or something else? This detail is clarified in wp-admin with a preceding label:
I suppose the simplest way to tackle this would be to mimic wp-admin and add a prefix. Are there other ways, could/should publish date and modified date be split into separate fields?
cc @WordPress/gutenberg-design @ntsekouras @oandregal for feedback.
Edit: Based on discussion below, let's start simply by adding the prefix:
The text was updated successfully, but these errors were encountered: