Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullquote: Theme defined padding is overridden by default #60646

Closed
iamtakashi opened this issue Apr 10, 2024 · 3 comments · Fixed by #60649
Closed

Pullquote: Theme defined padding is overridden by default #60646

iamtakashi opened this issue Apr 10, 2024 · 3 comments · Fixed by #60649
Assignees
Labels
[Block] Pullquote Affects the Pullquote Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@iamtakashi
Copy link

Description

The theme-defined padding values for the pull quote block are no longer working. They seem to be overridden by the default values. I've tested this with TT4, but it's not a theme-specific issue.

Step-by-step reproduction instructions

  1. Add a pull quote block in the editor.
  2. Make sure the active theme has a custom padding.
  3. See the block on the front of the site.
  4. Notice the difference in the vertical paddings

Screenshots, screen recording, code snippet

Gutenberg plugin inactive (expected) 👍
CleanShot 2024-04-10 at 23 23 10@2x

Gutenberg plugin active 😩
CleanShot 2024-04-10 at 23 25 57@2x

Environment info

WP 6.5.2
Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@iamtakashi iamtakashi added the [Type] Bug An existing feature does not function as intended label Apr 10, 2024
@andrewserong
Copy link
Contributor

andrewserong commented Apr 11, 2024

@tellthemachines is this related to the recent specificity reduction work? It looks like this rule has higher specificity than the global styles rules, so I'm wondering if it can be reduced, too 🤔:

@andrewserong andrewserong added the [Block] Pullquote Affects the Pullquote Block label Apr 11, 2024
@tellthemachines
Copy link
Contributor

@andrewserong yes that would be a good one to try reducing! I think as a general rule, styles from block-library should have minimum specificity.

@andrewserong
Copy link
Contributor

Great! I'll throw up a quick PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pullquote Affects the Pullquote Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
3 participants