New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme patterns should not have irrelevant DataViews actions #61945

Closed

richtabor opened this issue May 24, 2024 · 2 comments

Labels

[Feature] Data Views [Feature] Patterns [Feature] Site Editor [Type] Bug

Member

richtabor commented May 24, 2024 •

edited

Loading

Description

You can't move a theme's pattern to the trash/delete it, but there's a control for it.
You can't "Edit" a theme's pattern — instead it opens the home page in the Site Editor.

Both of these should be omitted, because you can't edit theme patterns (currently) and you can't delete them.

Step-by-step reproduction instructions

Open the site editor with a theme that has patterns (Twenty Twenty Four).
Select "Patterns."
Select a theme pattern (represented by a lock icon).
Select the vertical ellipsis dropdown.
Choose "Move to Trash" and "Edit" to reproduce.

Screenshots, screen recording, code snippet

CleanShot.2024-05-24.at.09.39.50.mp4

Environment info

Trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

richtabor added [Type] Bug [Feature] Patterns [Feature] Site Editor [Feature] Data Views labels

Member Author

richtabor commented May 24, 2024

Note that we're already filtering some controls, like "Rename" and "Export as JSON" to not render for theme patterns.

Member Author

richtabor commented May 24, 2024

Duplicate of #61787, let's fix this for 6.6.

richtabor closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment