Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify publishing flow between post and site editor - technical refinements #62694

Open
ntsekouras opened this issue Jun 20, 2024 · 2 comments
Open
Labels
[Type] Code Quality Issues or PRs that relate to code quality

Comments

@ntsekouras
Copy link
Contributor

ntsekouras commented Jun 20, 2024

This issue can be considered as the second part of: #59878 in order to properly fully unify the publishing flow between post and site editors.

Currently the publishing flow seems and is similar in terms of UI, but we still need to have some follow ups to consolidate some functionality in a better way.

The extra use cases in site editor include:

  1. Fix duplicate saving panels. This is related to the next item and we need to look into how to best consolidate save panels and button in editor package.
  2. Activating/previewing a theme (change of labels, callbacks, etc..). See customSaveButton in Editor component.
  3. The save button in site editor's sidebar (view mode) renders the save panel in a Modal
  4. Some specific logic for how to handle the save when making changes to global styles page
  5. Some cleanup is needed and let's refactor a bit where we can, while doing these follow ups (ex)

Let's track the refinement of the flow and UI in a separate issue to keep the technical improvement separate.

@ntsekouras ntsekouras added the [Type] Code Quality Issues or PRs that relate to code quality label Jun 20, 2024
@youknowriad
Copy link
Contributor

Anything missing here. Should we close it or are there some quick wins to do still.

@ntsekouras
Copy link
Contributor Author

Should we close it or are there some quick wins to do still.

No, let's keep it open and I'll see to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

No branches or pull requests

2 participants