Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages grid: Improve the preview field #63719

Open
jameskoster opened this issue Jul 18, 2024 · 2 comments · May be fixed by #65331
Open

Pages grid: Improve the preview field #63719

jameskoster opened this issue Jul 18, 2024 · 2 comments · May be fixed by #65331
Assignees
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

When a site doesn't use featured images for pages (not uncommon) the grid view is lacklustre:

Screenshot 2024-07-18 at 18 23 19

The gray thumbnails look a bit broken, or like a loading state that never resolves. How could this be improved?

One option to try is loading the content preview, similar to the templates grid.

A more long-term solution could be to allow the user to decide via in the view options menu:

Screenshot 2024-07-18 at 18 40 21

cc @ellatrix @richtabor

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Jul 18, 2024
@jorgefilipecosta jorgefilipecosta self-assigned this Jul 22, 2024
@jasmussen
Copy link
Contributor

Content preview sounds like a compelling feature to lift over from the Patterns section. But there are some performance considerations especially for very long pages. Since it already exists for patterns, I wonder: can we apply it as a fallback to the Featured Image to start? That way you'd always avoid the gray blotch. We might be able to add the drop-down option later on, should you want to see only that.

@jameskoster
Copy link
Contributor Author

I'm not entirely convinced about the fallback, in most cases a content preview is probably more useful so it seems a bit strange to prioritise the featured image. It may also be confusing why different pages have different preview types.

It would be good to get some technical feedback on the performance side of things. I'm not sure that rendering page previews would be all that different to template previews? So if we're doing it in one (two) places already, why not here as well?

The gray blotch could also be improved by clarifying that it relates to an image. We might use the gray diagonal stroke like the Image block placeholder state.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Status: Now
Development

Successfully merging a pull request may close this issue.

3 participants