Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block-insertion-points missing between innerBlock-elements #64222

Open
2 tasks done
digitalex11 opened this issue Aug 3, 2024 · 7 comments · Fixed by #64229
Open
2 tasks done

block-insertion-points missing between innerBlock-elements #64222

digitalex11 opened this issue Aug 3, 2024 · 7 comments · Fixed by #64229
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended

Comments

@digitalex11
Copy link

Description

I have two problems with block-insertion-points (lines with plus icon) in my custom blocks:

1. block with innerBlocks with orientation: horizontal with line-break
block-insertion-points are not appearing when mouse hovers between elements in second line, in first line everything is working as expected.

2. block with scrolled innerBlocks content
this problem occurs in a custom horizontal slider component (also innerBlocks with orientation: horizontal):
block-insertion-points are not appearing when mouse hovers between elements that are not in the initially visible area (when slider is scrolled)

case 1 could also be reproduced in the core/buttons block (see step by step instructions)

buttons

Step-by-step reproduction instructions

  1. create a core/buttons block
  2. create multiple buttons inside core/buttons so that the buttons break into a second line
  3. mouse-hover between buttons in second line: block-insertion-point will not appear

Screenshots, screen recording, code snippet

No response

Environment info

I am using:
MAC OS 13.4.1
Chrome 127.0.6533.88
Wordpress 6.6.1

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@digitalex11 digitalex11 added the [Type] Bug An existing feature does not function as intended label Aug 3, 2024
@Mamaduka Mamaduka added the [Feature] Inserter The main way to insert blocks using the + button in the editing interface label Aug 3, 2024
@Mamaduka
Copy link
Member

Mamaduka commented Aug 3, 2024

@digitalex11, does the in-between inserter work correctly on the second line if you select the very first block on the first line?

This might be the same issue as #53315. My comment provides additional details: #53315 (comment).

@t-hamano
Copy link
Contributor

t-hamano commented Aug 3, 2024

I was just testing this issue and it seems that the in-between inserter does not work on wrapped blocks, regardless of what block is selected.

Similar problems seem to occur in the Social Icons block and the Row block as well.

5fb1718e0412a2059d63ea2bead2a0f4.mp4

@digitalex11
Copy link
Author

digitalex11 commented Aug 3, 2024

@Mamaduka , no, the problem also occurs if first block ist selected.
@t-hamano , thanks for your video. Thats exactly the problem. It also occurs on the Grid block. It seems to affect all blocks with orientation: horizontal and line-breaks

@digitalex11
Copy link
Author

Here a video of the second case in my slider block:

slider.mp4

@t-hamano
Copy link
Contributor

t-hamano commented Aug 4, 2024

#64229 was automatically linked to close this issue, but note that #64229 does not resolve this issue.

@Mamaduka
Copy link
Member

@t-hamano, we should re-open this correct?

@t-hamano
Copy link
Contributor

Yes, thanks for noticing 😅

@t-hamano t-hamano reopened this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants