Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable blocks should still be available in List View when zoomed out #64260

Closed
richtabor opened this issue Aug 5, 2024 · 4 comments · Fixed by #65202
Closed

Selectable blocks should still be available in List View when zoomed out #64260

richtabor opened this issue Aug 5, 2024 · 4 comments · Fixed by #65202
Assignees
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

Currently if you engage zoom out view, the top-level blocks you can select are no longer available within List View. I'd expect that selectable blocks would be available in List View, even when zoomed out.

CleanShot.2024-08-05.at.10.11.39.mp4

Related: #63870.

@richtabor richtabor added [Type] Bug An existing feature does not function as intended [Feature] Zoom Out labels Aug 5, 2024
@cat-og
Copy link

cat-og commented Sep 9, 2024

I found that similarly, the Header and Footer blocks also disappear from the List View if you add a new pattern while zoomed out.

Unlike the selectable elements, these blocks did not reappear after returning to standard zoom.

Screen.Capture.on.2024-09-08.at.23-10-21.mp4

@getdave
Copy link
Contributor

getdave commented Sep 10, 2024

I found that similarly, the Header and Footer blocks also disappear from the List View if you add a new pattern while zoomed out.

This seems to be because getEnabledClientIdsTreeUnmemoized checks for blocks whose blockEditingMode is disabled and if so then doesn't include in the clientIds passed to List View.

We can't make an exception here so we need to decide if locking template parts is the correct choice in Zoom Out.

@richtabor
Copy link
Member Author

richtabor commented Sep 11, 2024

decide if locking template parts is the correct choice in Zoom Out.

Now that it is possible to select and edit the header from page editing as well, it could be fine to have the same while zoomed out.

@getdave
Copy link
Contributor

getdave commented Sep 12, 2024

#65202 will fix the List View for Zoomed Out. The Header/Footer bit would need another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended
Projects
Development

Successfully merging a pull request may close this issue.

3 participants