-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs
: unify styles and remove overrides
#64307
Labels
Needs Design Feedback
Needs general design feedback.
Comments
Thanks for documenting the discussions @DaniGuardiola!
|
I'm addressing both overflow and "fill layout" in #64371 |
Addressing 3 in #65387. Updated 1 and 3 to reflect current state. |
Updated state of 2. |
I just wanted to post a recap of the pending
@DaniGuardiola am i missing anything? |
Thank you, that's useful @ciampo. I will reorganize the description later to better describe the current state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're in the process of stabilizing the new
Tabs
component, see #52997Since it's already been in the wild for some time, there's been enough time for it to be used in multiple places across Gutenberg, and this has surfaced many needs expressed in the form of style overrides. This is helpful as it's information that we can now use to improve the base component - however, we're actively discouraging style overrides as they inevitably result is breakages and wasted developer time down the line, which in turn severely limits the ability for us to evolve the component.
For this reason, there have been conversations across multiple issues and PRs about certain aspects of
Tabs
going on for a while. In this issue, I intend to enumerate and centralize all these aspects with the following goals:Tabs
component to reasonably cover its necessary UI needs.I ask for the help from @WordPress/gutenberg-components and @WordPress/gutenberg-design to reach good compromises here and unblock this work. I intend to leave enough time for everyone to leave their thoughts and to test related changes as this effort evolves to reflect the latest decisions or explorations. That said, we need to get this wrapped up to unblock the rest of the work.
Feel free to chime in, and please use numbers to clearly refer to each of the discussions you intend to contribute to. Thank you!
Design aspects of
Tabs
being discussedI'm adding a quick summary of each discussion as well as a "current status" or "resolution" summary to provide visibility. Keep in mind that I might have missed something or gotten something wrong - I'm only human. Just let me know and I'll correct it.
These summaries also have the purpose of clearly expressing the current direction to give everyone a fair chance to reply now, before they are considered resolved and closed, at least for the foreseeable future.
Improve display of many tabs in narrow containers #64093
Sometimes there can be too many tabs and they don't fit in the container. In this discussion, several ideas are compared, including scroll and wrapping strategies.
Status: 🔴 open
Current state: scrolling implemented, need to further experiment with more clear indicators of overflow and enhanced interaction patterns.
Try: Improved tabbed sidebar styles #61974
There is currently a style override in sidebars that expands the size of the tab container and makes tabs expand as well in equal sizes ("fill" style). This PR removes that override. In this PR, there is also general discussion of "fill" vs "hug" styles, as well as (if "fill" is implemented natively) whether the labels should be centered or left-aligned.
Status: 🔴 open
Current state: consensus on the necessity of a "fill-with-centered-label" variant (necessary at least for icon labels). Still discussing whether sidebars should be "hug" or "fill", and whether a "fill-with-left-aligned-label" is necessary. Implemented a way to achieve both layouts without variants, instead tablists are "hug" by default, and the user can tweak the
width
property and which makes tabs adapt in a "fill" manner. This has been implemented inTabs
: tweak sizing and overflow behavior of TabList #64371 which includes an interactive Storybook story to set how this works (video in the description).Tabs: add vertical indicator animation #62879 (comment) (vertical indicator styles)
After the implementation of a vertical indicator in
Tabs
, we realized that there is disparity between multiple instances of this indicator's styles.Status: 🔴 open
Current state: discussing and experimenting in Tabs: unify vertical tabs styles #65387.
Please let me know if I missed anything!
The text was updated successfully, but these errors were encountered: