Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Background Image popover for Cover block media controls #64703

Open
richtabor opened this issue Aug 22, 2024 · 0 comments
Open

Use Background Image popover for Cover block media controls #64703

richtabor opened this issue Aug 22, 2024 · 0 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

I propose we use the same media controls that we use for the group block's "Background Image" PanelBody, for a "Media" PanelBody within the cover block's Inspector.

It would closely resemble the site logo's "Media" panel for uploading a logo.

This could pave the way for putting the cover block's media in the Styles panel of the Inspector in a future iteration, so you don't have to flip between Settings and Styles to adjust the focal point and change the overlay, etc.

CleanShot 2024-08-21 at 21 11 08

CleanShot 2024-08-21 at 21 12 29

As an aside, the group block's background image popover lacks a bit of finesse. Would be great if they were shared so that fine-tuning one does the other as well.

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant