Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] Block settings - link DISABLED, lightbox ENABLED - should show UI while block override is active, but hide UI if override is removed #65157

Open
github-actions bot opened this issue Sep 9, 2024 · 1 comment
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Sep 9, 2024

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

Block settings - link DISABLED, lightbox ENABLED - should show UI while block override is active, but hide UI if override is removed

Test path

/test/e2e/specs/editor/blocks/image.spec.js

Errors

[2024-09-09T14:23:09.448Z] Test passed after 1 failed attempt on trunk.
[2024-09-12T10:02:04.851Z] Test passed after 1 failed attempt on enable/prop-migration-rules-components-package.
[2024-09-17T19:20:42.208Z] Test passed after 1 failed attempt on fix/full-page-navigation-server-state.
[2024-09-18T23:53:18.352Z] Test passed after 1 failed attempt on trunk.
[2024-09-24T10:47:56.794Z] Test passed after 1 failed attempt on trunk.
[2024-09-24T12:41:14.163Z] Test passed after 1 failed attempt on update/button-block-toggle-group-ctrl.
[2024-09-25T18:25:22.546Z] Test passed after 1 failed attempt on wp/6.7.
[2024-09-27T19:21:22.104Z] Test passed after 1 failed attempt on try/inspector-controls-no-margin.
[2024-09-30T11:53:02.899Z] Test passed after 1 failed attempt on trunk.
[2024-10-02T01:33:37.352Z] Test passed after 1 failed attempt on update/remove-goto-screenheader-back.
[2024-10-10T15:45:49.300Z] Test passed after 1 failed attempt on fix/pattern-blocks-in-write-mode-again-v2.
[2024-10-16T09:58:56.106Z] Test passed after 1 failed attempt on trunk.
[2024-10-22T03:23:28.763Z] Test passed after 1 failed attempt on update/playwright-latest.
[2024-11-06T10:02:05.835Z] Test passed after 1 failed attempt on trunk.
[2024-11-27T15:17:13.090Z] Test passed after 1 failed attempt on update/ariakit-0-4-12.
[2024-12-05T09:35:07.706Z] Test passed after 1 failed attempt on update/range-control-marks-styles.
[2024-12-09T10:04:35.572Z] Test passed after 1 failed attempt on update/npm-audit-fix.
[2024-12-09T12:39:37.451Z] Test passed after 1 failed attempt on update/query-direct-children-to-ancestor.
[2024-12-11T20:33:29.712Z] Test passed after 1 failed attempt on line-height-deprecate-size.
[2024-12-12T14:09:33.294Z] Test passed after 1 failed attempt on trunk.
[2024-12-18T09:27:28.849Z] Test passed after 1 failed attempt on try/post-type-archive-search-types-api.
[2024-12-18T14:47:05.257Z] Test passed after 1 failed attempt on add/64944-with-sync-event.
Error: apiRequestContext.fetch: socket hang up
Call log:
  - → PUT http://localhost:8889/index.php?rest_route=/wp/v2/plugins/gutenberg-test-plugins/lightbox-allow-editing-false-enabled-false
  -   user-agent: Playwright/1.48.1 (x64; ubuntu 22.04) node/20.18 CI/1
  -   accept: */*
  -   accept-encoding: gzip,deflate,br
  -   X-WP-Nonce: cf5d88573f
  -   content-type: application/json
  -   content-length: 21
  -   cookie: wordpress_test_cookie=WP%20Cookie%20check; wordpress_logged_in_23778236db82f19306f247e20a353a99=admin%7C1734705092%7CNCP20GTJrE86ASe4oFiLSwU2fkUQhAR2eI7hZMkQF2E%7C7784c8d33e5983442ed3f2bdefaffadce6bc3a1d4d086c568677d4cb3586a92d; wp-settings-time-1=1734532446

    at RequestUtils.rest (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/rest.ts:119:39)
    at RequestUtils.deactivatePlugin (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/plugins.ts:96:13)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/image.spec.js:914:5
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Sep 9, 2024
github-actions bot referenced this issue Sep 9, 2024
Unlinked contributors: realthemes.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
github-actions bot referenced this issue Sep 18, 2024
* Fix linter warnings

* Replace the postType if current post type is different

* Remove currentPostType logic

* Default to posts if is_singular

* Update test_rendering_post_template_with_main_query_loop_already_started test

* Add test for query loop not inside a singular query

* Revert changes to QueryContent

* Show query type control only when on a template

* Move template logic to QueryInspectorControls

* Ensure inherit value is updated when not in a template

* Update comment

* Rename showDefaultControl to isTemplate

* Get postType from context

* Add a check for singular content based on available post type

* Move inherit reset to a useEffect

* Move isTemplate logic to QueryContent

* Fix lint warnings

Unlinked contributors: alaczek, autumnfjeld.

Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: creativecoder <grantmkin@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
github-actions bot referenced this issue Sep 24, 2024
* Site Editor: Make resizable frame compatible with RTL languages

* Update packages/edit-site/src/components/resizable-frame/index.js

Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net>

* Fix dragging behaviour

---------

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: stokesman <presstoke@git.wordpress.org>
github-actions bot referenced this issue Sep 25, 2024
…65639)

* Move `is_custom` check to page case

* Check themeSlug in conditional

* Use `post.slug` directly

Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
github-actions bot referenced this issue Sep 30, 2024
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
github-actions bot referenced this issue Oct 16, 2024
Co-authored-by: michalczaplinski <czapla@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>
github-actions bot referenced this issue Nov 6, 2024
…image is set for post (#65896)

* feature: created toggle control to set content image as feature image if no feature image is set

* Fix: docs build

* revert: php changes for feature image

* feature: created toolbar control to set image as feature image is post don't have feature image set

* feature: created block settings & added proper notices for success message

* update: added required block context for feature image control

* update: set feature image control as per suggestion

* remove: unnessary isFeature image attribute

* rename: feature image control

* Fix: query loop issue

* Fix: typo in set featured image

* update as per suggestions

* Fix: minor feedback

* Fix: minor issue
Copy link
Author

This issue has gone 15 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Nov 23, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2024
@github-actions github-actions bot reopened this Nov 27, 2024
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Nov 28, 2024
github-actions bot referenced this issue Dec 12, 2024
* Fix: close button is not working

* Remove unnecessary CSS

---------

Unlinked contributors: parthVataliya16.

Co-authored-by: PARTHVATALIYA <parthvataliya@git.wordpress.org>
Co-authored-by: draganescu <andraganescu@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: miminari <mimitips@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

No branches or pull requests

0 participants