Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child blocks are displayed in the block inserter and block visibility doesn't work #65687

Closed
t-hamano opened this issue Sep 27, 2024 · 2 comments · Fixed by #65700
Closed

Child blocks are displayed in the block inserter and block visibility doesn't work #65687

t-hamano opened this issue Sep 27, 2024 · 2 comments · Fixed by #65700
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Sep 27, 2024

What problem does this address?

I found two issues in the trunk:

  • Child blocks that have a specific parent, such as the List Item, are displayed. When you click on the block, it will say "Block "{blockName}" can't be inserted.". (This may be a new specification)
  • "Manage block visibility" doesn't work.

I used git bisect and it looks like this issue occurred in #65490.

957141419a3cef7be97099ce0c69e8f8.mp4

cc @youknowriad @andrewserong @jorgefilipecosta

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Sep 27, 2024
@youknowriad
Copy link
Contributor

Thanks for catching the bug and creating the issue. It seems the new behavior to "compute insertion point" on the fly should only apply to specific conditions, not all the conditions of when a block is visible or not.

So it's like we need two different kind of selectors:

  • Can insert block
  • Is block visible

I'll explore something.

@youknowriad
Copy link
Contributor

We should have e2e tests about the "manage block visibility" thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants