Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom out disengages unexpectedly when double-clicking to select all text #65750

Closed
richtabor opened this issue Sep 30, 2024 · 8 comments
Closed
Assignees
Labels
[Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

Once you are able to select nested blocks to edit with #65702, you will be able to double-click to select all the text contents of a block—but doing so (a common practice to select all text within a block) will disengage zoom out unexpectedly.

Perhaps enable the listener directly on the section, not all blocks.

372108257-cdb11aa7-2ecc-48f9-bb96-04c1c179b867.mp4

Related #64573.

@getdave
Copy link
Contributor

getdave commented Oct 1, 2024

Just noting that I don't believe this is going to be targeted for 6.7 so I think we can remove from the board 🙇

@getdave
Copy link
Contributor

getdave commented Oct 1, 2024

Maybe fixed by #65782

@getdave getdave moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.7 Editor Tasks Oct 1, 2024
@getdave
Copy link
Contributor

getdave commented Oct 11, 2024

@colorful-tones @ndiego @kevin940726 I'm removing this form 6.7 board as I don't believe it's targeting 6.7 as it's discussed possible future functionality and features.

@draganescu
Copy link
Contributor

Can we only preserver double click on the workspace area (the gray zone)?

@richtabor
Copy link
Member Author

Can we only preserver double click on the workspace area (the gray zone)?

I think it'll be a nice experience if you double-click and you zoom into the pattern you created. i.e. #65884

@afercia
Copy link
Contributor

afercia commented Nov 11, 2024

you will be able to double-click to select all the text contents of a block

Just to be accurate, the native behavior is that a double-click selects a word. The triple-click selects an entire block of text.

This double-click conflict was originally reported in this comment: #65702 (comment)

Double-click to exit zoom out:
I'm not sure this is an ideal interaction in the first place. It would be totally unexpected, especially when the double click is performed on a block of text. I expect the native click behavior to always work:

  • Single clilck: places the cursor in an editable area.
  • Double click: selects a word, whether it's in an editable area or not doesn't matter.
  • Triple click: selects the entire block of text, whether it's in an editable area or not doesn't matter.

These are native, expected, interactions that shouldn't be hijacked.

@richtabor
Copy link
Member Author

Noting that this is only necessary if we proceed with #65702.

@richtabor
Copy link
Member Author

I'm going to go ahead and close this as not-planned per the feedback on #65702. It doesnt seem like #65702 is necessary to more forward currently.

@richtabor richtabor closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants