Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline formatting toolbar border radius clipping #66134

Closed
2 tasks done
stokesman opened this issue Oct 15, 2024 · 2 comments · Fixed by #66163
Closed
2 tasks done

Inline formatting toolbar border radius clipping #66134

stokesman opened this issue Oct 15, 2024 · 2 comments · Fixed by #66163
Assignees
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@stokesman
Copy link
Contributor

Description

The formatting toolbar’s corners are getting a little clipped. It appears to have came about in #64368

Step-by-step reproduction instructions

  1. Add an image block
  2. Add or focus the caption text
  3. Note the formatting toolbar’s clipped corners

Screenshots, screen recording, code snippet

Image

Environment info

  • Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@stokesman stokesman added the [Type] Bug An existing feature does not function as intended label Oct 15, 2024
@stokesman
Copy link
Contributor Author

@jameskoster, you’d perhaps be most wise on how to fix this. I see this in 6.7 beta but not in 6.6 so I think it would qualify for fixing in 6.7. Of course it’s not too critical.

@t-hamano t-hamano added the General Interface Parts of the UI which don't fall neatly under other labels. label Oct 16, 2024
@jameskoster
Copy link
Contributor

Good spot. There are a couple of things happening:

  1. This toolbar is wrapped in a Popover, the 4px radius of which is clipping the toolbar.
  2. Button groups in this toolbar have a background color, whereas groups in the regular block toolbar do not.

We need to explore updating the toolbar component to align with the new radius scale, but that's a 6.8 thing.

I'll open a PR for 6.7 to address this.

@jameskoster jameskoster self-assigned this Oct 16, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants