Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover block should not have additional controls when zoomed out #66206

Closed
richtabor opened this issue Oct 17, 2024 · 5 comments · Fixed by #66243
Closed

Cover block should not have additional controls when zoomed out #66206

richtabor opened this issue Oct 17, 2024 · 5 comments · Fixed by #66243
Assignees
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

Currently the Cover block maintains its additional toolbar controls when zoomed out. I propose the tooling when zoomed out should be consistent across blocks, instead of having one-off controls on some blocks.

Visual

Image

Note that the visual above is testing #66194.

@richtabor richtabor added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Zoom Out [Type] Bug An existing feature does not function as intended labels Oct 17, 2024
@draganescu
Copy link
Contributor

@youknowriad will this be auto solved by adding the edit mode to the zoom out view?

@youknowriad
Copy link
Contributor

How do you decide (generally speaking for all blocks), which toolbar buttons to show and which ones to hide in zoom-out? Or should we just remove all the "slots"? (all the toolbar buttons defined by the block itself as opposed to the ones added by the framework)

@ntsekouras
Copy link
Contributor

I was looking at this and have the same question with @youknowriad. It seems for some support toolbar buttons (like align) we have an extra check for blockEditingMode !== 'default' which essentially not renders them in zoom out. So it's not a specific problem to Cover block, but just a coincidence that we usually don't use many other blocks as pattern wrappers.

@talldan
Copy link
Contributor

talldan commented Oct 18, 2024

Some other issues were spotted over here - #66200 (comment)

  • Multi-selection group transform options show in the toolbar
  • Lock/Unlock options show in the toolbar for user locked blocks
  • Vertical alignment shows (observed on the columns block).

It's probably be easiest to hide all the slots as @youknowriad suggests.

@richtabor
Copy link
Member Author

How do you decide (generally speaking for all blocks), which toolbar buttons to show and which ones to hide in zoom-out? Or should we just remove all the "slots"? (all the toolbar buttons defined by the block itself as opposed to the ones added by the framework)

Yea, I don't think we'll have block-specific tools in the toolbar when zoomed out, only controls like the shuffle/change design and #66465.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants