Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured Image Field: Improve layout #66332

Open
gigitux opened this issue Oct 22, 2024 · 4 comments
Open

Featured Image Field: Improve layout #66332

gigitux opened this issue Oct 22, 2024 · 4 comments
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond

Comments

@gigitux
Copy link
Contributor

gigitux commented Oct 22, 2024

According to @jameskoster, we need to update the layout of the Featured Image Field Control layout:

I ask because out of conversations in other issues came a realisation that we might improve the design by making the 'Choose image..." button a drop zone:
image

Originally posted by @jameskoster in #64496 (comment)

@jameskoster
Copy link
Contributor

I don't think it's 100% certain that the featured image control should adopt this design. But there should be a file or media control option in the data forms api that does.

Related to this work is updating DropZone and FormFileUpload components. There's some related discussion in #65333. This might be considered a blocker here.

@ntsekouras
Copy link
Contributor

I don't think it's 100% certain that the featured image control should adopt this design. But there should be a file or media control option in the data forms api that does.

Should we close this one in favor of: #66403 then?

@gigitux
Copy link
Contributor Author

gigitux commented Oct 25, 2024

I’d suggest keeping it open, as although the Featured Image Field control has been merged, it remains a suboptimal solution. We’ll need to improve the current layout once we have access to the appropriate API.

@jameskoster
Copy link
Contributor

There's also the design discussion to be had around whether the featured image control should remain a bespoke UI outside of the post/page meta data form. Given the accessibility quandary, and additional maintenance required, I'd lean towards no, but it needs more input from @gutenberg-design.

@gigitux gigitux added the [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond label Oct 25, 2024
@gigitux gigitux mentioned this issue Sep 26, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond
Projects
None yet
Development

No branches or pull requests

3 participants