Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an eslint rule to use memize not lodash's memoize #6707

Closed
tofumatt opened this issue May 11, 2018 · 1 comment
Closed

Create an eslint rule to use memize not lodash's memoize #6707

tofumatt opened this issue May 11, 2018 · 1 comment
Assignees
Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Performance Related to performance efforts

Comments

@tofumatt
Copy link
Member

I didn't realise we should be using memize over lodash's built-in memoize, pointed out here: #6686 (comment)

I forget if we can make an eslint rule preventing us from importing it or at least warning us about it, but if so I'll make a PR so it doesn't happen again 😄

@tofumatt tofumatt added [Type] Performance Related to performance efforts [Type] Code Quality Issues or PRs that relate to code quality labels May 11, 2018
@tofumatt tofumatt self-assigned this May 11, 2018
@aduth
Copy link
Member

aduth commented May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Performance Related to performance efforts
Projects
None yet
Development

No branches or pull requests

2 participants