Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“withInstanceId” component uses incorrect capitalization of “ID” #6742

Closed
ZebulanStanphill opened this issue May 14, 2018 · 2 comments

Comments

@ZebulanStanphill
Copy link
Member

The issue

withInstanceId uses incorrect capitalization of “ID”. It should be “withInstanceID”. A variable used by the component, instanceId also uses incorrect capitalization.

https://github.com/WordPress/gutenberg/tree/master/components/higher-order/with-instance-id

Expected behavior

“ID” should be correctly capitalized in all functions, variables, etc. according to camelCase standards. Assuming I understand camelCase properly, “ID” and “UID” should always be entirely capitalized unless it is the first word in a name, in which case it should be entirely lowercase.

Related Issues and/or PRs

#6685
#6741

@chrisvanpatten
Copy link
Member

Not sure this is true; see #6741 (comment)

@gziolo
Copy link
Member

gziolo commented May 15, 2018

Let's track all occurrences in one issue. Closing this one in favor of #6741.

@gziolo gziolo closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants