Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Text component to utilise tokens #67794

Open
jameskoster opened this issue Dec 10, 2024 · 2 comments
Open

Update Text component to utilise tokens #67794

jameskoster opened this issue Dec 10, 2024 · 2 comments
Labels
Design System Issues related to the system of combining components according to best practices. [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Tokens were recently added for styling text using scss. This is documented on Storybook.

Let's discuss updating the Text component to utilise these tokens. By doing so we can hopefully close out issues like this one: #47735

@jameskoster jameskoster added [Package] Components /packages/components [Type] Enhancement A suggestion for improvement. Design System Issues related to the system of combining components according to best practices. labels Dec 10, 2024
@rinkalpagdar
Copy link
Contributor

@jameskoster, can you please provide more information about the issue? It would be helpful to reproduce it.

@jameskoster
Copy link
Contributor Author

@rinkalpagdar it's not currently possible to reference tokens from the design system relating to typography in the Text component.

It should be possible to utilise system tokens in properties like size, weight, lineHeight, and so on.

Additionally it should be possible to reference a specific style (a combination of font styles defined as scss mixins) rather than handling individual properties.

For example consumer should be able to do something like:

Hello

I hope that makes sense?

I seem to recall discussing this a bit with @ciampo but it looks like we didn't make any notes. Maybe he has some recollection 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System Issues related to the system of combining components according to best practices. [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
Status: No status
Development

No branches or pull requests

2 participants