Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arrow key navigation to the block switcher #696

Closed
afercia opened this issue May 6, 2017 · 3 comments · Fixed by #2989
Closed

Add arrow key navigation to the block switcher #696

afercia opened this issue May 6, 2017 · 3 comments · Fixed by #2989
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@afercia
Copy link
Contributor

afercia commented May 6, 2017

As done for the Inserter in #578 (see #515) the block switcher needs arrow keys navigation.

The required ARIA roles, states, and properties are split in a separate issue, see #695

block switcher
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label May 6, 2017
@afercia afercia mentioned this issue May 6, 2017
Merged
@aduth aduth added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take labels May 26, 2017
@afercia
Copy link
Contributor Author

afercia commented Aug 1, 2017

Or, consider to use the DropdownMenu component.

@afercia
Copy link
Contributor Author

afercia commented Oct 11, 2017 •
edited
Loading

The block switcher looks a bit different now but it still needs some accessibility and reusing the DropdownMenu component seems the best option.

@afercia
Copy link
Contributor Author

afercia commented Oct 11, 2017

See #2989

@afercia afercia mentioned this issue Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Components: Add a generic navigable menu component WordPress/gutenberg
3 participants
@karmatosed @afercia @aduth