Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Separator shown in More Options when template locked #7692

Closed
aduth opened this issue Jul 3, 2018 · 2 comments
Closed

Blocks: Separator shown in More Options when template locked #7692

aduth opened this issue Jul 3, 2018 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@aduth
Copy link
Member

aduth commented Jul 3, 2018

Describe the bug

When a template is locked, at least within a nested context, a separator is shown even though there are no options below it. The logic of the menu should not show the separator unless there are options below.

image

To Reproduce

Steps to reproduce the behavior:

TBD. Will be introduced with Column block in #7234.

Expected behavior

No separator if options not below it.
@aduth aduth added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Jul 3, 2018
@nfmohit nfmohit mentioned this issue Jul 6, 2018
Merged
4 tasks
@aduth aduth added the [Status] In Progress Tracking issues with work in progress label Jul 6, 2018
@aduth
Copy link
Member Author

aduth commented Aug 6, 2018

Fixed by #7751

FYI @nfmohit-wpmudev : For future reference, GitHub supports keyword conventions which allow associated issues to be auto-closed upon merge. See: https://help.github.com/articles/closing-issues-using-keywords/

@nfmohit
Copy link
Member

nfmohit commented Aug 6, 2018

Wow, didn't know that. Will use it from now on. Thank you so much for letting me know @aduth ❤

@mtias mtias closed this as completed Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtias @aduth @nfmohit