Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple block can be in a "isHovered" state #8133

Closed
afercia opened this issue Jul 23, 2018 · 6 comments
Closed

Multiple block can be in a "isHovered" state #8133

afercia opened this issue Jul 23, 2018 · 6 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Milestone

Comments

@afercia
Copy link
Contributor

afercia commented Jul 23, 2018

Noticed while investigating on improvements for #8033.

There should be just one block in a "isHovered" state at a time. However, the implementation fails and multiple blocks can be in a "isHovered" state, with the related UI and styles displayed:

screen shot 2018-07-23 at 13 03 13

To reproduce:

  • hover a block
  • hover the "More Options" ellipsis button on the right
  • wait for the tooltip to appear
  • at this point, move the mouse up vertically, to hover the right area of the previous block
  • both blocks are now in a "isHovered" state

Same happens with the "block mover" buttons on the left.

Repeating the same steps for all the blocks above, all the blocks become "isHovered".

@afercia afercia added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Jul 23, 2018
@designsimply
Copy link
Member

Tested and confirmed and found that this only happens when moving the mouse very quickly from one control element after the tooltip is triggered to another control element such as the more options, mover, or the block label that appears on hover. (1m20s)

Tested using WordPress 4.9.7 and Gutenberg 3.3.0 both in Safari 11.1.2 and Firefox 61.0.1 on macOS 10.13.6.

Related: #2122

@afercia
Copy link
Contributor Author

afercia commented Jul 25, 2018

In my testing it happens also without being very fast when moving the mouse. It seems to always happen when moving the pointer vertically in the area highlighted in the screenshot below:

hover

@designsimply
Copy link
Member

For completeness, may I ask what OS and browser versions you are using for testing?

@afercia
Copy link
Contributor Author

afercia commented Jul 25, 2018

I've tested it on mac, latest Chrome and Firefox.

@mtias mtias added this to the Future: 5.1 milestone Nov 12, 2018
@jorgefilipecosta
Copy link
Member

Hi @afercia thank you for reporting this issue. I tried to replicate this issue after all the design changes that happened and I was not able to do it, it was probably solved as a side effect of the design changes. If I missed something feel free to reopen the issue.

@afercia
Copy link
Contributor Author

afercia commented Apr 23, 2019

Hi @jorgefilipecosta yep, can't reproduce any onger. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants