Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left/Right aligning a cover image block hides the block toolbar on mobile. #8203

Closed
kjellr opened this issue Jul 25, 2018 · 2 comments
Closed

Left/Right aligning a cover image block hides the block toolbar on mobile. #8203

kjellr opened this issue Jul 25, 2018 · 2 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Jul 25, 2018

Describe the bug

At smaller screen breakpoints, setting a Cover Image block to align to the left/right completely hides the Block toolbar. This makes it impossible to change the alignment back to any other setting, to change the text alignment, or to change the image.

To Reproduce

  1. Insert a cover image block.
  2. Choose left or right alignment from the block toolbar.
  3. The block toolbar will disappear.

This happens whether or not you insert an image first.

Expected behavior

I expected to still have access to the block toolbar.

Screenshots

cover-image-mobile

Tested in
iOS 11.4.1, Safari
Mac OS 10.13.6, Safari 11.1.2
Mac OS 10.13.6, Chrome 67.0.3396.99
Gutenberg 3.3.0
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Jul 25, 2018
@kjellr kjellr mentioned this issue Jul 25, 2018
Closed
7 tasks
@ZebulanStanphill
Copy link
Member

I do not think this block should even have float alignment controls in the first place.

@ZebulanStanphill ZebulanStanphill mentioned this issue Aug 9, 2018
Closed
@mtias mtias added the [Block] Cover Affects the Cover Block - used to display content laid over a background image label Oct 27, 2018
@jorgefilipecosta
Copy link
Member

Hi @kjellr thank you for reporting this problem. With the recent changes to the cover block, I'm not being able to reproduce this issue anymore.
If I'm missing something feel free to reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mtias @kjellr @jorgefilipecosta @ZebulanStanphill