Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: "Edit as HTML" minifies the code #8798

Closed
manake opened this issue Aug 9, 2018 · 5 comments
Closed

Table: "Edit as HTML" minifies the code #8798

manake opened this issue Aug 9, 2018 · 5 comments
Labels
[Type] Help Request Help with setup, implementation, or "How do I?" questions.

Comments

@manake
Copy link

manake commented Aug 9, 2018

I have a table and clicking "Edit as HTML" shows table's HTML but it's all minified (even though I pasted it as clean).

Can the block not compress/destroy the code that I pasted?

@manake
Copy link
Author

manake commented Aug 9, 2018

Whatever is happening with this block this is not usable...

I see some random "This block has been modified externally." like 10th time already while editing this single table.

  1. I think there is some problem with adding "custom CSS class" to it and that breaks the block.
  2. Create table block > edit html > edit something in that html > block breaks. (But if I just paste the same exact HTML in the editor then it works.)

I use this block for the first time ever and I can't make a table so far without irreversible error. Frustrating.

@designsimply designsimply added the [Type] Help Request Help with setup, implementation, or "How do I?" questions. label Aug 9, 2018
@manake
Copy link
Author

manake commented Aug 10, 2018

It'd say this is a "bug" rather than "help request". I don't need help because I already managed to make it work but I'm reporting this because this involved a lot of frustration and wasted time.

It's completely unclear under what circumstances "This block has been modified externally." appears. It may be one/some of the following:

  • If I edit table's class in "HTML mode" then the block breaks.
  • Or when I add "colspan" then it can break.
  • Or when I convert "td" to "th" in "HTML mode".

I don't know. I know that I'm trying to build a table but it prevents me from doing this.

And it leaves me no choice but to delete the block and re-create it every time.

Proposed solution
"This block has been modified externally." should never appear.

@swissspidy
Copy link
Member

This has come up multiple times in the past, see for example #6826. Current discussion happens at #7604.

@ZebulanStanphill
Copy link
Member

Also note that the Table block is getting some rewrites and enhancements. See #6923 and #8767.

@manake
Copy link
Author

manake commented Aug 10, 2018

Thank you for your responses. I'll close this if the discussion is happening elsewhere.

Last thing I want to emphasize: If it wasn't destroying my work (if I could edit HTML without "This block has been modified externally.") then I would be happy with this block. The remaining UI changes are not important to me. I only want it to not break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Help Request Help with setup, implementation, or "How do I?" questions.
Projects
None yet
Development

No branches or pull requests

4 participants