Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox styles are inconsistent #8825

Closed
maddisondesigns opened this issue Aug 10, 2018 · 4 comments
Closed

Checkbox styles are inconsistent #8825

maddisondesigns opened this issue Aug 10, 2018 · 4 comments
Labels
[Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable

Comments

@maddisondesigns
Copy link

Describe the bug
There are so many inconsistencies within the Gutenberg UI. In 3.5.0 the toggle switches have been replaced with checkboxes and they've also been styled to make them more noticeable.

The UI should be consistent. If you have checkboxes in one part of the UI, then they should match checkboxes used in another part of the UI, especially when you're talking about the exact same screen.

The checkboxes in the More menu look completely different to the checkboxes in the sidebar.

screenshot_774

To Reproduce
Steps to reproduce the behavior:

  1. Edit a page and click on the More menu
  2. Compare with the checkboxes in the sidebar, in the Document tab

Expected behavior
The UI should be consistent, and it's not. This is just one of many inconsistencies with the current UI.

Desktop (please complete the following information):

  • OS: macOS Sierra 10.12.6
  • Browser: Firefox Quantum 61.0.1 (64-bit)
  • Gutenberg: 3.5.0
@chrisvanpatten
Copy link
Contributor

They use different styles here because the "checkboxes" in the popover menu aren't actually checkbox form inputs.

They're just icons indicating the menu item is selected/active, like checkmarks in menus in the macOS menubar:

screen shot 2018-08-10 at 10 43 42

Perhaps there's an argument that the popover menu shouldn't use a checkmark symbol/icon, but it definitely shouldn't use the checkbox styles.

@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Aug 10, 2018

See #8588 for the reasoning behind the current look of checkboxes and why they are used in place of toggles in some cases.

@designsimply designsimply added the [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable label Aug 10, 2018
@designsimply
Copy link
Member

Closing due to the explanations in #8588.

@maddisondesigns
Copy link
Author

That seems fair enough. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable
Projects
None yet
Development

No branches or pull requests

4 participants